You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/24 13:42:10 UTC

[GitHub] [cloudstack] FilippoProjetto opened a new issue #4173: Prometheus integration: prometheus.exporter.enable marked as dynamic config

FilippoProjetto opened a new issue #4173:
URL: https://github.com/apache/cloudstack/issues/4173


   <!--
   Verify first that your issue/request is not already reported on GitHub.
   Also test if the latest release and master branch are affected too.
   Always add information AFTER of these HTML comments, but no need to delete the comments.
   -->
   
   ##### ISSUE TYPE
   <!-- Pick one below and delete the rest -->
    * Bug Report
   
   ##### COMPONENT NAME
   <!--
   Categorize the issue, e.g. API, VR, VPN, UI, etc.
   -->
   ~~~
   Prometheus integration.
   ~~~
   
   ##### CLOUDSTACK VERSION
   <!--
   New line separated list of affected versions, commit ID for issues on master branch.
   -->
   
   ~~~
   All.
   ~~~
   
   ##### SUMMARY
   <!-- Explain the problem/feature briefly -->
   
   The database stores the `prometheus.exporter.enable` as a dynamic configuration parameter while it is not (as correctly stated in the PR description: https://github.com/apache/cloudstack/pull/2287#issue-145389779). 
   
   ![Screenshot 2020-06-24 at 14 41 09](https://user-images.githubusercontent.com/5737687/85567507-d4998780-b628-11ea-9781-019e0c6b4f6b.png)
   
   It's not a big deal but confusing.
   
   It looks like the bug is in the ConfigKey constructor call:  https://github.com/apache/cloudstack/blob/5471802f862dd617f63d12eb56c9aa62759e4309/plugins/integrations/prometheus/src/main/java/org/apache/cloudstack/metrics/PrometheusExporterServer.java#L25
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd closed issue #4173: Prometheus integration: prometheus.exporter.enable marked as dynamic config

Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #4173:
URL: https://github.com/apache/cloudstack/issues/4173


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org