You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "tvalentyn (via GitHub)" <gi...@apache.org> on 2023/12/11 10:30:08 UTC

[PR] Apply mitigation #27330 for 2.53.0 [beam]

tvalentyn opened a new pull request, #29703:
URL: https://github.com/apache/beam/pull/29703

   I am investigating a process corruption that became very pronounced in streaming pipelines after protobuf 4 upgrade #27330 .
   Since:
   1) there is still no rootcause for #27330;
   2) some customers insist that Beam must support protobuf v4;
   3) issue seems limited to streaming pipelines;
   4) protobuf 4.25 is expected  to be forwards-compatible with 3.20.x ,
   
   I propose to install Protobuf 3.20 by default into Beam SDK container until we have a fix for #27330.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Apply mitigation #27330 for 2.53.0 [beam]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #29703:
URL: https://github.com/apache/beam/pull/29703#issuecomment-1849770445

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/29703?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base [(`a96fa74`)](https://app.codecov.io/gh/apache/beam/commit/a96fa74f0ccb8d0c5490ba2872bfd52675a15558?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 37.99% compared to head [(`8371f8f`)](https://app.codecov.io/gh/apache/beam/pull/29703?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 37.99%.
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #29703   +/-   ##
   =======================================
     Coverage   37.99%   37.99%           
   =======================================
     Files         691      691           
     Lines      101334   101334           
   =======================================
     Hits        38502    38502           
     Misses      61234    61234           
     Partials     1598     1598           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/beam/pull/29703/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [go](https://app.codecov.io/gh/apache/beam/pull/29703/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.56% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/29703?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Apply mitigation #27330 for 2.53.0 [beam]

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #29703:
URL: https://github.com/apache/beam/pull/29703#issuecomment-1849767679

   R: @jrmccluskey 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Apply mitigation #27330 for 2.53.0 [beam]

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #29703:
URL: https://github.com/apache/beam/pull/29703#issuecomment-1850446247

   Thanks, added e173b4d16bdbd31ed970e9121bfdeace353a6499 to fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Apply mitigation #27330 for 2.53.0 [beam]

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #29703:
URL: https://github.com/apache/beam/pull/29703#issuecomment-1850504457

   looks like fast implementation is not available on 3.11 with protobuf 3 :(.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Apply mitigation #27330 for 2.53.0 [beam]

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #29703:
URL: https://github.com/apache/beam/pull/29703#issuecomment-1850489365

   looks like still failing for 3.11, looking further


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Apply mitigation #27330 for 2.53.0 [beam]

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn closed pull request #29703: Apply mitigation #27330 for 2.53.0 
URL: https://github.com/apache/beam/pull/29703


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Apply mitigation #27330 for 2.53.0 [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29703:
URL: https://github.com/apache/beam/pull/29703#issuecomment-1849769800

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Apply mitigation #27330 for 2.53.0 [beam]

Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #29703:
URL: https://github.com/apache/beam/pull/29703#issuecomment-1850180409

   The Docker pre-commit is failing with a dependency issue:
   
   ```
   89.88 [nltk_data] Downloading package stopwords to /root/nltk_data...
   89.94 [nltk_data]   Unzipping corpora/stopwords.zip.
   90.14 Traceback (most recent call last):
   90.14   File "<string>", line 1, in <module>
   90.14 AssertionError
   90.14 Container does not include required Beam dependencies or has conflicting dependencies. If Beam dependencies have changed, you need to regenerate base_image_requirements.txt files. See: https://s.apache.org/beam-python-requirements-generate
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org