[GitHub] [beam] ahmedabu98 commented on pull request #25706: [25705] Refactor BigQuery SchemaTransforms naming

["ahmedabu98 (via GitHub)" <gi...@apache.org>]

ahmedabu98 commented on PR #25706:
URL: https://github.com/apache/beam/pull/25706#issuecomment-1453848508

   The read method here uses the [`EXPORT`](https://github.com/apache/beam/blob/39cab94361bc44e8b48257385d37d8978ab7fc02/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java#L864) read method. There's a a `DIRECT` read schematransform here ([BigQueryDirectReadSchemaTransformProvider](https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryDirectReadSchemaTransformProvider.java)), maybe this should also have a more precise name and include "Export"?
   
   Similarly with the write schematransform, it uses the FILE_LOADS method. In comparison, there is the `STORAGE_WRITE_API` schematransform here ([BigQueryStorageWriteApiSchemaTransformProvider](https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/providers/BigQueryStorageWriteApiSchemaTransformProvider.java))
   
   P.S. I know this makes the names super long, so I'm open to a better way of doing this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org