You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by darionyaphet <gi...@git.apache.org> on 2016/07/17 05:03:44 UTC
[GitHub] storm pull request #1570: [STORM-1975] Support default value for KafkaBolt
GitHub user darionyaphet opened a pull request:
https://github.com/apache/storm/pull/1570
[STORM-1975] Support default value for KafkaBolt
[STORM-1975 Support default value for KafkaBolt](https://issues.apache.org/jira/browse/STORM-1975)
Support some default values (acks , key and value serializer) for kafka bolt
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/darionyaphet/storm STORM-1975
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1570.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1570
----
commit a08af55c7ae3d4e49448c007b43dcf7826a83032
Author: darionyaphet <da...@gmail.com>
Date: 2016-07-17T05:01:42Z
STORM-1975 : Support default value for KafkaBolt
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1570: [STORM-1975] Support default value for KafkaBolt
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1570
@darionyaphet given that old consumer api is deprecated and we've new storm-kafka-client lets get our development efforts with storm-kafka-client. Unless there is a bug I am against adding any new features to storm-kafka.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1570: [STORM-1975] Support default value for KafkaBolt
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1570
@harshach @darionyaphet I don't think we're in a position to deprecate storm-kafka yet for two reasons:
1. storm-kafka-client does not have feature parity with storm-kafka yet (e.g. bolt, Trident support)
2. storm-kafka-client requires kafka 0.10.x. It will take some time for all users to upgrade to that version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1570: [STORM-1975] Support default value for KafkaBolt
Posted by darionyaphet <gi...@git.apache.org>.
Github user darionyaphet commented on the issue:
https://github.com/apache/storm/pull/1570
@harshach `Storm-kafka-client` is a new spout to consume data from Kafka . It seems not include `KafkaBolt`. Is it good to port `Storm-kafka`'s `KafkaBolt` into `Storm-kafka-client` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---