You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2011/04/10 07:25:44 UTC
Re: svn commit: r1090715 - /subversion/trunk/subversion/libsvn_client/commit_util.c
On Apr 9, 2011 7:54 PM, <rh...@apache.org> wrote:
>
> Author: rhuijben
> Date: Sat Apr 9 23:54:31 2011
> New Revision: 1090715
>
> URL: http://svn.apache.org/viewvc?rev=1090715&view=rev
> Log:
> Two small optimizations in the commit handler: Assume absolute paths are
> already absolute and only send fulltexts for local additions, instead of
> for additions and copies.
It is unclear that item->path is absolute. Ideally, renaming the field would
be best. At a minimm, add a comment here.
>...
Cheers,
-g
RE: svn commit: r1090715 - /subversion/trunk/subversion/libsvn_client/commit_util.c
Posted by Greg Stein <gs...@gmail.com>.
On Apr 10, 2011 3:26 PM, "Bert Huijben" <be...@qqmail.nl> wrote:
>
>
>
> > -----Original Message-----
> > From: Greg Stein [mailto:gstein@gmail.com]
> > Sent: zondag 10 april 2011 7:26
> > To: dev@subversion.apache.org
> > Subject: Re: svn commit: r1090715 -
> > /subversion/trunk/subversion/libsvn_client/commit_util.c
> >
> > On Apr 9, 2011 7:54 PM, <rh...@apache.org> wrote:
> > >
> > > Author: rhuijben
> > > Date: Sat Apr 9 23:54:31 2011
> > > New Revision: 1090715
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1090715&view=rev
> > > Log:
> > > Two small optimizations in the commit handler: Assume absolute paths
are
> > > already absolute and only send fulltexts for local additions, instead
of
> > > for additions and copies.
> >
> > It is unclear that item->path is absolute. Ideally, renaming the field
> would
> > be best. At a minimum, add a comment here.
>
> This field in commit_item3_t and its older cousins *2_t and *_t are
> documented to be absolute paths since the early days (r841696, or r1622),
> when the log message editor api was introduced.
Ah. Thanks. IOW, it just hasn't caught up to our recent naming scheme. ...
Fair enuf!
Cheers,
-g
RE: svn commit: r1090715 - /subversion/trunk/subversion/libsvn_client/commit_util.c
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: Greg Stein [mailto:gstein@gmail.com]
> Sent: zondag 10 april 2011 7:26
> To: dev@subversion.apache.org
> Subject: Re: svn commit: r1090715 -
> /subversion/trunk/subversion/libsvn_client/commit_util.c
>
> On Apr 9, 2011 7:54 PM, <rh...@apache.org> wrote:
> >
> > Author: rhuijben
> > Date: Sat Apr 9 23:54:31 2011
> > New Revision: 1090715
> >
> > URL: http://svn.apache.org/viewvc?rev=1090715&view=rev
> > Log:
> > Two small optimizations in the commit handler: Assume absolute paths are
> > already absolute and only send fulltexts for local additions, instead of
> > for additions and copies.
>
> It is unclear that item->path is absolute. Ideally, renaming the field
would
> be best. At a minimum, add a comment here.
This field in commit_item3_t and its older cousins *2_t and *_t are
documented to be absolute paths since the early days (r841696, or r1622),
when the log message editor api was introduced.
Bert