You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/09/20 19:29:54 UTC
[kudu-CR] [docs] Add tip on dealing with planned TS downtime
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11486
Change subject: [docs] Add tip on dealing with planned TS downtime
......................................................................
[docs] Add tip on dealing with planned TS downtime
Rendering available at
https://github.com/wdberkeley/kudu/blob/docfollowerunavailablesec/docs/administration.adoc.
Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
---
M docs/administration.adoc
1 file changed, 37 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/11486/1
--
To view, visit http://gerrit.cloudera.org:8080/11486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
Gerrit-Change-Number: 11486
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add tip on dealing with planned TS downtime
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11486 )
Change subject: [docs] Add tip on dealing with planned TS downtime
......................................................................
Removed reviewer Kudu Jenkins.
--
To view, visit http://gerrit.cloudera.org:8080/11486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
Gerrit-Change-Number: 11486
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add tip on dealing with planned TS downtime
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11486 )
Change subject: [docs] Add tip on dealing with planned TS downtime
......................................................................
[docs] Add tip on dealing with planned TS downtime
Rendering available at
https://github.com/wdberkeley/kudu/blob/docfollowerunavailablesec/docs/administration.adoc.
Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
Reviewed-on: http://gerrit.cloudera.org:8080/11486
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Will Berkeley <wd...@gmail.com>
---
M docs/administration.adoc
1 file changed, 37 insertions(+), 0 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Grant Henke: Looks good to me, approved
Will Berkeley: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
Gerrit-Change-Number: 11486
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add tip on dealing with planned TS downtime
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Andrew Wong, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11486
to look at the new patch set (#2).
Change subject: [docs] Add tip on dealing with planned TS downtime
......................................................................
[docs] Add tip on dealing with planned TS downtime
Rendering available at
https://github.com/wdberkeley/kudu/blob/docfollowerunavailablesec/docs/administration.adoc.
Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
---
M docs/administration.adoc
1 file changed, 37 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/11486/2
--
To view, visit http://gerrit.cloudera.org:8080/11486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
Gerrit-Change-Number: 11486
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add tip on dealing with planned TS downtime
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11486 )
Change subject: [docs] Add tip on dealing with planned TS downtime
......................................................................
Patch Set 2: Verified+1
Short-circuiting jenkins for docs-only change.
--
To view, visit http://gerrit.cloudera.org:8080/11486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
Gerrit-Change-Number: 11486
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 21:32:46 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add tip on dealing with planned TS downtime
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11486 )
Change subject: [docs] Add tip on dealing with planned TS downtime
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11486/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/11486/1/docs/administration.adoc@1126
PS1, Line 1126: If a single tablet server is brought down temporarily in a healthy cluster, all
Is the first sentence relevant? Maybe just talking about the replication aspect is all that's needed.
I am thinking you could start with something like:
"If a single tablet server is brought down for more than `--follower_unavailable_considered_failed_sec`..."
http://gerrit.cloudera.org:8080/#/c/11486/1/docs/administration.adoc@1157
PS1, Line 1157: On Kudu versions prior to 1.8, the `--force` flag must be provided in the above
maybe prepend "NOTE:"
--
To view, visit http://gerrit.cloudera.org:8080/11486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
Gerrit-Change-Number: 11486
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 20:45:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add tip on dealing with planned TS downtime
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11486 )
Change subject: [docs] Add tip on dealing with planned TS downtime
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
Gerrit-Change-Number: 11486
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 21:31:42 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add tip on dealing with planned TS downtime
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11486 )
Change subject: [docs] Add tip on dealing with planned TS downtime
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11486/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/11486/1/docs/administration.adoc@1151
PS1, Line 1151: $ sudo -u kudu kudu tserver set_flag <tserver_address> follower_unavailable_considered_failed_sec <original_value>
> I don't want to, for a couple of reasons:
Ack
--
To view, visit http://gerrit.cloudera.org:8080/11486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
Gerrit-Change-Number: 11486
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 21:20:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add tip on dealing with planned TS downtime
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11486 )
Change subject: [docs] Add tip on dealing with planned TS downtime
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
Gerrit-Change-Number: 11486
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] [docs] Add tip on dealing with planned TS downtime
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11486 )
Change subject: [docs] Add tip on dealing with planned TS downtime
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
Gerrit-Change-Number: 11486
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 20:39:22 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add tip on dealing with planned TS downtime
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11486 )
Change subject: [docs] Add tip on dealing with planned TS downtime
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/11486/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/11486/1/docs/administration.adoc@1126
PS1, Line 1126: If a single tablet server is brought down temporarily in a healthy cluster, all
> Is the first sentence relevant? Maybe just talking about the replication as
It establishes the consequences of downtime for a single tablet server, in full, rather than only highlighting the downside. The point being that a user investigating what will happen to their Kudu cluster when they bring down one tablet server can read this section and understand the implications of their plan.
I also wanted to be careful to establish the idea that the downtime is planned and done in a healthy cluster-- I do not want users to think they can apply this advice if they have unexpected downtime.
http://gerrit.cloudera.org:8080/#/c/11486/1/docs/administration.adoc@1140
PS1, Line 1140: on each tablet server:
> "for each tablet server", since we don't have to be local to run the comman
Done
http://gerrit.cloudera.org:8080/#/c/11486/1/docs/administration.adoc@1151
PS1, Line 1151: $ sudo -u kudu kudu tserver set_flag <tserver_address> follower_unavailable_considered_failed_sec <original_value>
> Do you think it's worth adding a sentence to call out the `get_flags` tool
I don't want to, for a couple of reasons:
0. It's safe to assume pretty much everyone uses the default.
1. Technically the flag can differ between tablet servers. If I include it in the instructions and we insist on prevision it's N more commands people need to run when they probably don't...they just need the default of 300 N times.
2. The command to get the value is a little gross
sudo -u kudu kudu tserver get_flags <tserver_addr> --all_flags --format=csv | grep follower_unavailable_considered_failed_sec | cut -d',' -f2
http://gerrit.cloudera.org:8080/#/c/11486/1/docs/administration.adoc@1157
PS1, Line 1157: On Kudu versions prior to 1.8, the `--force` flag must be provided in the above
> maybe prepend "NOTE:"
Done
--
To view, visit http://gerrit.cloudera.org:8080/11486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
Gerrit-Change-Number: 11486
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 21:18:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add tip on dealing with planned TS downtime
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11486 )
Change subject: [docs] Add tip on dealing with planned TS downtime
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11486/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/11486/1/docs/administration.adoc@1140
PS1, Line 1140: on each tablet server:
"for each tablet server", since we don't have to be local to run the command
http://gerrit.cloudera.org:8080/#/c/11486/1/docs/administration.adoc@1151
PS1, Line 1151: $ sudo -u kudu kudu tserver set_flag <tserver_address> follower_unavailable_considered_failed_sec <original_value>
Do you think it's worth adding a sentence to call out the `get_flags` tool to get the original values?
--
To view, visit http://gerrit.cloudera.org:8080/11486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I55a992a00f35945187e02c55594edc6e261a72c4
Gerrit-Change-Number: 11486
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 20:45:52 +0000
Gerrit-HasComments: Yes