You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/07/23 17:01:16 UTC
[Impala-ASF-CR] modified MetaStoreEventsProcessor to catch multiple invalid configuration keys in one go.
sharanitha.harish@cloudera.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13894
Change subject: modified MetaStoreEventsProcessor to catch multiple invalid configuration keys in one go.
......................................................................
modified MetaStoreEventsProcessor to catch multiple invalid configuration keys in one go.
Change-Id: Ie6f4b22a810714c7f2a3c35b7010781a8a071493
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
2 files changed, 43 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/13894/1
--
To view, visit http://gerrit.cloudera.org:8080/13894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6f4b22a810714c7f2a3c35b7010781a8a071493
Gerrit-Change-Number: 13894
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] modified MetaStoreEventsProcessor to catch multiple invalid configuration keys in one go.
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
sharanitha.harish@cloudera.com has abandoned this change. ( http://gerrit.cloudera.org:8080/13894 )
Change subject: modified MetaStoreEventsProcessor to catch multiple invalid configuration keys in one go.
......................................................................
Abandoned
made some changes to rectify the same patch
--
To view, visit http://gerrit.cloudera.org:8080/13894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie6f4b22a810714c7f2a3c35b7010781a8a071493
Gerrit-Change-Number: 13894
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] modified MetaStoreEventsProcessor to catch multiple invalid configuration keys in one go.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13894 )
Change subject: modified MetaStoreEventsProcessor to catch multiple invalid configuration keys in one go.
......................................................................
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java:
http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@242
PS1, Line 242: * Test if the error messages are caught appropriately when multiple config keys are invalid.
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@247
PS1, Line 247: String actual_errorMessages="[Unexpected configuration value for hive.metastore.notifications.add.thrift.objects"+
line too long (118 > 90)
http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@248
PS1, Line 248: " in Hive Metastore. Expected: true Found: false, Unexpected configuration value for hive.metastore.dml"+
line too long (117 > 90)
http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@252
PS1, Line 252: List<MetastoreEventProcessorConfig> configKeys = new ArrayList<MetastoreEventProcessorConfig>() {
line too long (101 > 90)
http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@259
PS1, Line 259: Mockito.when(test.getConfigValueFromMetastore(config.getValidator().getConfigKey(), "")).
line too long (95 > 90)
http://gerrit.cloudera.org:8080/#/c/13894/1/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@262
PS1, Line 262: for (MetastoreEventProcessorConfig config : test.getEventProcessorConfigsToValidate()) {
line too long (92 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/13894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f4b22a810714c7f2a3c35b7010781a8a071493
Gerrit-Change-Number: 13894
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jul 2019 17:02:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] modified MetaStoreEventsProcessor to catch multiple invalid configuration keys in one go.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13894 )
Change subject: modified MetaStoreEventsProcessor to catch multiple invalid configuration keys in one go.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3961/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13894
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f4b22a810714c7f2a3c35b7010781a8a071493
Gerrit-Change-Number: 13894
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Jul 2019 17:42:20 +0000
Gerrit-HasComments: No