You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/12 02:41:02 UTC
[GitHub] [dubbo] horizonzy commented on a change in pull request #8775: fix issue-8695:DefaultFuture turn off logging optimization for Channel
horizonzy commented on a change in pull request #8775:
URL: https://github.com/apache/dubbo/pull/8775#discussion_r706731636
##########
File path: dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/support/DefaultFuture.java
##########
@@ -251,14 +251,12 @@ private String getTimeoutMessage(boolean scan) {
+ (sent > 0 ? " client elapsed: " + (sent - start)
+ " ms, server elapsed: " + (nowTimestamp - sent)
: " elapsed: " + (nowTimestamp - start)) + " ms, timeout: "
- + timeout + " ms, request: " + (logger.isDebugEnabled() ? request : getRequestWithoutData()) + ", channel: " + channel.getLocalAddress()
+ + timeout + " ms, request: " + (logger.isDebugEnabled() ? request : getRequestWithoutData(request)) + ", channel: " + channel.getLocalAddress()
+ " -> " + channel.getRemoteAddress();
}
- private Request getRequestWithoutData() {
- Request newRequest = request.copy();
- newRequest.setData(null);
- return newRequest;
+ private static Request getRequestWithoutData(Request request) {
Review comment:
This method can be removed. We can use request. copyWithoutData() directly.
##########
File path: dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/support/DefaultFuture.java
##########
@@ -147,7 +147,7 @@ public static void closeChannel(Channel channel) {
disconnectResponse.setErrorMessage("Channel " +
channel +
" is inactive. Directly return the unFinished request : " +
- future.getRequest());
+ getRequestWithoutData(future.getRequest()));
Review comment:
Here use `logger.isDebugEnabled()` to judge is print data also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org