[jira] Commented: (DERBY-2242) Convert jdbcapi/metadata.java to JUnit test.

["Myrna van Lunteren (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12540327 ] 

Myrna van Lunteren commented on DERBY-2242:
-------------------------------------------

I implemented the TODO for testUnimplementedSQLObjectAttributes fixture with revision 590476.
I made a first cut at implementing getBestRowIdentifier by taking the tests from bestrowidentifier.sql and metadata.java with revision 592240.

However, I now have a question on the basic set up for this test as explained in the javadoc.
The javadoc indicates that for methods that return a resultset,  there are to be 2 versions; one fixture that modifies the database, and one that doesn't.
With, if I understand this correctly, the idea that the ones that don't modify the database are to be used for the upgrade tests.
However, I'm wondering if this idea was dropped?

The javadoc appears unfinished, there are only tests for getTables and getColumns that have a modify and non-modify version, and the upgrade tests appear to execute any test that start with 'test' except for 'testGetTablesModify'.

Clarification please? 
If I don't hear anything, I'm going to adjust the javadoc on the modify/non modify bit to only apply to getTables and getColumns tests.


> Convert jdbcapi/metadata.java to JUnit test.
> --------------------------------------------
>
>                 Key: DERBY-2242
>                 URL: https://issues.apache.org/jira/browse/DERBY-2242
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>            Reporter: Daniel John Debrunner
>            Assignee: Myrna van Lunteren
>            Priority: Minor
>
> Create a test for DatabaseMetaData that matches the testing of metadata.java.
> Should also handle the odbc_metadata variant.
> Once created can be used by other tests to ensure database meta data works in other situations, such as upgrade and read-only databases.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.