[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #312: GUACAMOLE-1201: Fix audio input issue on mme

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #312:
URL: https://github.com/apache/guacamole-server/pull/312#discussion_r518991030



##########
File path: src/protocols/rdp/channels/audio-input/audio-buffer.c
##########
@@ -242,6 +338,7 @@ void guac_rdp_audio_buffer_write(guac_rdp_audio_buffer* audio_buffer,
         pthread_mutex_unlock(&(audio_buffer->lock));
         return;
     }
+    pthread_mutex_unlock(&(audio_buffer->lock));

Review comment:
       This mutex is documented as guarding all access to `audio_buffer`. Unlocking things here and then operating on the `audio_buffer` without holding the mutex looks like a threadsafety issue.
   
   If you are certain this is safe, can you describe how that has been verified?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org