[GitHub] [kafka] efeg commented on a change in pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

[GitBox <gi...@apache.org>]

efeg commented on a change in pull request #8579:
URL: https://github.com/apache/kafka/pull/8579#discussion_r417460683



##########
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##########
@@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String,
                     "that the partition is being moved")
                   partitionsWithError += topicPartition
 
+                case Errors.UNKNOWN_TOPIC_OR_PARTITION =>
+                  warn(s"Remote broker does not host the partition $topicPartition, which could indicate " +
+                    "that the partition is being created or deleted.")

Review comment:
       @ijuma I feel that `info` has an implicit implication that everything is "fine"; hence, I am concerned that it might be overlooked when investigating an issue.
   
   The current broadcast-based approach in Kafka is just one way -- which arguably, has room for improvement -- of implementing state propagation for topic creation/deletion, and this error is a side-effect of it. Extended occurrence of this error can hamper the read/write availability as well as state consistency. Thus, even if `UNKNOWN_TOPIC_OR_PARTITION` is expected under the current design/implementation, it is definitely not desired.
   
   What are your thoughts?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org