You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/01/29 21:35:16 UTC
[GitHub] zeppelin pull request #1958: [MINOR] Prevent log NPE in ResourcePoolUtils.ge...
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/1958
[MINOR] Prevent log NPE in ResourcePoolUtils.getAllResourcesExcept()
### What is this PR for?
ResourcePoolUtils.getAllResourcesExcept() sometimes throws NPE. Which doesn't really need to be logged.
```
ResourcePoolUtils.java[getAllResourcesExcept]:64) -
java.lang.NullPointerException
at org.apache.zeppelin.resource.ResourcePoolUtils.getAllResourcesExcept(ResourcePoolUtils.java:58)
at org.apache.zeppelin.resource.ResourcePoolUtils.getAllResources(ResourcePoolUtils.java:36)
at org.apache.zeppelin.helium.Helium.suggestApp(Helium.java:264)
at org.apache.zeppelin.rest.HeliumRestApi.suggest(HeliumRestApi.java:84)
```
### What type of PR is it?
Improvement
### Todos
* [x] - handle null thrift client
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin npe_getallresources
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1958.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1958
----
commit 862d86f7e7b41d82e5047c86aafbcbd5b632cde3
Author: Lee moon soo <mo...@apache.org>
Date: 2017-01-29T21:31:18Z
prevent logging NPE in ResourcePoolUtils.getAllResourcesExcept()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1958: [MINOR] Prevent log NPE in ResourcePoolUtils.ge...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1958
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1958: [MINOR] Prevent log NPE in ResourcePoolUtils.getAllRes...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1958
Merge to master if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1958: [MINOR] Prevent log NPE in ResourcePoolUtils.getAllRes...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1958
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1958: [MINOR] Prevent log NPE in ResourcePoolUtils.getAllRes...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1958
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---