You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Filipe Manana (JIRA)" <ji...@apache.org> on 2010/09/27 00:35:36 UTC
[jira] Created: (HAMA-288) Typo might lead to null tasks getting
assigned to groom servers
Typo might lead to null tasks getting assigned to groom servers
---------------------------------------------------------------
Key: HAMA-288
URL: https://issues.apache.org/jira/browse/HAMA-288
Project: Hama
Issue Type: Bug
Reporter: Filipe Manana
While continuing my navigation through Hama found a typo that might lead to null tasks getting assigned to groom servers.
Patch attached.
cheers
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-288) Typo might lead to null tasks getting
assigned to groom servers
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana updated HAMA-288:
-------------------------------
Attachment: hama-288-better-variable-names.patch
This 2nd patch gives better names to the variables to avoid such typos in the future.
task => taskList
for (Task task : taskList) {
if (task != null) {
// etc...
}
}
> Typo might lead to null tasks getting assigned to groom servers
> ---------------------------------------------------------------
>
> Key: HAMA-288
> URL: https://issues.apache.org/jira/browse/HAMA-288
> Project: Hama
> Issue Type: Bug
> Reporter: Filipe Manana
> Attachments: hama-288-better-variable-names.patch, hama-288.patch
>
>
> While continuing my navigation through Hama found a typo that might lead to null tasks getting assigned to groom servers.
> Patch attached.
> cheers
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-288) Typo might lead to null tasks getting
assigned to groom servers
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915987#action_12915987 ]
Filipe Manana commented on HAMA-288:
------------------------------------
Edward,
did you miss the review of this patch? Seems a bit more critical this one.
cheers
> Typo might lead to null tasks getting assigned to groom servers
> ---------------------------------------------------------------
>
> Key: HAMA-288
> URL: https://issues.apache.org/jira/browse/HAMA-288
> Project: Hama
> Issue Type: Bug
> Reporter: Filipe Manana
> Attachments: hama-288-better-variable-names.patch, hama-288.patch
>
>
> While continuing my navigation through Hama found a typo that might lead to null tasks getting assigned to groom servers.
> Patch attached.
> cheers
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HAMA-288) Typo might lead to null tasks getting
assigned to groom servers
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon resolved HAMA-288.
---------------------------------
Assignee: Filipe Manana
Fix Version/s: 0.2.0
Resolution: Fixed
Thanks, Filipe! I've just committed this.
> Typo might lead to null tasks getting assigned to groom servers
> ---------------------------------------------------------------
>
> Key: HAMA-288
> URL: https://issues.apache.org/jira/browse/HAMA-288
> Project: Hama
> Issue Type: Bug
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Fix For: 0.2.0
>
> Attachments: hama-288-better-variable-names.patch, hama-288.patch
>
>
> While continuing my navigation through Hama found a typo that might lead to null tasks getting assigned to groom servers.
> Patch attached.
> cheers
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-288) Typo might lead to null tasks getting
assigned to groom servers
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana updated HAMA-288:
-------------------------------
Attachment: hama-288.patch
> Typo might lead to null tasks getting assigned to groom servers
> ---------------------------------------------------------------
>
> Key: HAMA-288
> URL: https://issues.apache.org/jira/browse/HAMA-288
> Project: Hama
> Issue Type: Bug
> Reporter: Filipe Manana
> Attachments: hama-288.patch
>
>
> While continuing my navigation through Hama found a typo that might lead to null tasks getting assigned to groom servers.
> Patch attached.
> cheers
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-288) Typo might lead to null tasks getting
assigned to groom servers
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915998#action_12915998 ]
Edward J. Yoon commented on HAMA-288:
-------------------------------------
Oh, very simple but serious bug. +1
> Typo might lead to null tasks getting assigned to groom servers
> ---------------------------------------------------------------
>
> Key: HAMA-288
> URL: https://issues.apache.org/jira/browse/HAMA-288
> Project: Hama
> Issue Type: Bug
> Reporter: Filipe Manana
> Attachments: hama-288-better-variable-names.patch, hama-288.patch
>
>
> While continuing my navigation through Hama found a typo that might lead to null tasks getting assigned to groom servers.
> Patch attached.
> cheers
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.