You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@rocketmq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/04 11:07:01 UTC
[jira] [Commented] (ROCKETMQ-44) Duplicated codes in
DefaultMessageStore.getEarliestMessageTime and
DefaultMessageStore.getMessageStoreTimeStamp
[ https://issues.apache.org/jira/browse/ROCKETMQ-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114247#comment-16114247 ]
ASF GitHub Bot commented on ROCKETMQ-44:
----------------------------------------
Github user Ritabrata-TW commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/134#discussion_r131365055
--- Diff: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -1215,9 +1210,13 @@ public TopicRouteData getTopicRouteInfoFromNameServer(final String topic, final
assert response != null;
switch (response.getCode()) {
case ResponseCode.TOPIC_NOT_EXIST: {
- if (!topic.equals(MixAll.DEFAULT_TOPIC))
+ if (allowTopicNotExist && !topic.equals(MixAll.DEFAULT_TOPIC)) {
log.warn("get Topic [{}] RouteInfoFromNameServer is not exist value", topic);
- break;
+ break;
--- End diff --
@shroman Ahh. I get you now. Making the change and pushing. Thanks
> Duplicated codes in DefaultMessageStore.getEarliestMessageTime and DefaultMessageStore.getMessageStoreTimeStamp
> ---------------------------------------------------------------------------------------------------------------
>
> Key: ROCKETMQ-44
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-44
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: Wu Sheng
> Assignee: vongosling
> Priority: Minor
> Fix For: 4.2.0-incubating
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)