You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/04 17:00:33 UTC

[GitHub] [spark] srowen commented on a diff in pull request #39326: [SPARK-41800][BUILD] Upgrade commons-compress to 1.22

srowen commented on code in PR #39326:
URL: https://github.com/apache/spark/pull/39326#discussion_r1061696714


##########
core/pom.xml:
##########
@@ -181,6 +181,10 @@
       <groupId>commons-codec</groupId>
       <artifactId>commons-codec</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.apache.commons</groupId>
+      <artifactId>commons-compress</artifactId>
+    </dependency>

Review Comment:
   If this isn't just a breaking change in commons-compress, then I feel like we have two different versions of common-compress in play, which could explain why just adding the dependency explicitly changed behavior



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org