[jira] [Commented] (TINKERPOP-1640) ComputerVerificationStrategy gives false errors

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888669#comment-15888669 ] 

ASF GitHub Bot commented on TINKERPOP-1640:
-------------------------------------------

GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/566

    TINKERPOP-1640: ComputerVerificationStrategy gives false errors

    https://issues.apache.org/jira/browse/TINKERPOP-1640
    
    Split `ComputerVerificationStrategy` into two strategies:
    
        1. `ComputerVerificationStrategy` -- does all the `VerificationException` analyses.
        2. `ComputerFinalizationStrategy` -- does all the `GraphComputing` step configurations.
    
    This was enabled so that users who are certain that the verification logic of `ComputerVerificationStrategy` is too strict for their particular traversal, can turn off verification and still have a proper executing OLAP traversal.
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1640

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/566.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #566
    
----

----


> ComputerVerificationStrategy gives false errors
> -----------------------------------------------
>
>                 Key: TINKERPOP-1640
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1640
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.2.4
>            Reporter: Daniel Kuppitz
>            Assignee: Marko A. Rodriguez
>
> I've added a new complex test that fails in OLAP. Unfortunately the test runner only marks the test as "ignored" as that's what we usually we want when a {{VerificationException}} is thrown. However, in this case the exception ("It is not possible to access more than a path element's id on GraphComputer: ...") is wrong.
> Another issue that I just noticed is, that the same test throw serialization exceptions in the {{\*Translator\*}} test suites.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)