[jira] [Commented] (FLINK-3454) Add test dependencies on packaged jars

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262366#comment-15262366 ] 

ASF GitHub Bot commented on FLINK-3454:
---------------------------------------

Github user greghogan commented on the pull request:

    https://github.com/apache/flink/pull/1698#issuecomment-215472110
  
    @tillrohrmann I count three issues:
    1) this current PR guarantees that for a full parallel the jar will be built before the dependent test
    2) when testing or verifying an individual module the jar file must be discovered in the classpath
    3) running in an IDE there may be no jar file but instead a classes folder on the classpath, so we would need to package the folder in a jar file


> Add test dependencies on packaged jars
> --------------------------------------
>
>                 Key: FLINK-3454
>                 URL: https://issues.apache.org/jira/browse/FLINK-3454
>             Project: Flink
>          Issue Type: Bug
>          Components: Scala Shell, YARN Client
>    Affects Versions: 1.0.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>
> The following test from flink-scala-shell requires that the flink-ml jar be compiled.
> {noformat}
> Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 213.66 sec <<< FAILURE! - in org.apache.flink.api.scala.ScalaShellITCase
> testSubmissionOfExternalLibrary(org.apache.flink.api.scala.ScalaShellITCase)  Time elapsed: 0.028 sec  <<< FAILURE!
> java.lang.AssertionError: assertion failed
> 	at scala.Predef$.assert(Predef.scala:151)
> 	at org.apache.flink.api.scala.ScalaShellITCase.testSubmissionOfExternalLibrary(ScalaShellITCase.scala:169)
> {noformat}
> flink-yarn-tests depends on flink-dist:
> {noformat}
> Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.971 sec <<< FAILURE! - in org.apache.flink.yarn.UtilsTest
> testUberjarLocator(org.apache.flink.yarn.UtilsTest)  Time elapsed: 0.803 sec  <<< FAILURE!
> java.lang.AssertionError: null
> 	at org.junit.Assert.fail(Assert.java:86)
> 	at org.junit.Assert.assertTrue(Assert.java:41)
> 	at org.junit.Assert.assertNotNull(Assert.java:621)
> 	at org.junit.Assert.assertNotNull(Assert.java:631)
> 	at org.apache.flink.yarn.UtilsTest.testUberjarLocator(UtilsTest.java:42)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)