You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/03/30 00:43:39 UTC
[GitHub] [phoenix] kadirozde opened a new pull request #747: PHOENIX-5807 Index rows without empty column should be treated as unv…
kadirozde opened a new pull request #747: PHOENIX-5807 Index rows without empty column should be treated as unv…
URL: https://github.com/apache/phoenix/pull/747
…erified
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #747: PHOENIX-5807 Index rows without empty column should be treated as unv…
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on a change in pull request #747: PHOENIX-5807 Index rows without empty column should be treated as unv…
URL: https://github.com/apache/phoenix/pull/747#discussion_r399897386
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java
##########
@@ -169,6 +171,48 @@ public void testDeleteNonExistingRow() throws Exception {
}
}
+ @Test
+ public void testIndexRowWithoutEmptyColumn() throws Exception {
+ if (async) {
+ // No need to run the same test twice one for async = true and the other for async = false
+ return;
+ }
+ long scn;
+ String dataTableName = generateUniqueName();
+ String indexTableName = generateUniqueName();
+ try (Connection conn = DriverManager.getConnection(getUrl())) {
+ populateTable(dataTableName); // with two rows ('a', 'ab', 'abc', 'abcd') and ('b', 'bc', 'bcd', 'bcde')
+ Thread.sleep(1000);
Review comment:
This can be done with EnvironmentEdgeManager rather than a sleep, and that's faster/safer than a sleep. Just remember to increment by at least one after any DDL or DML to be able to read it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] kadirozde commented on a change in pull request #747: PHOENIX-5807 Index rows without empty column should be treated as unv…
Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #747: PHOENIX-5807 Index rows without empty column should be treated as unv…
URL: https://github.com/apache/phoenix/pull/747#discussion_r399930562
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java
##########
@@ -169,6 +171,48 @@ public void testDeleteNonExistingRow() throws Exception {
}
}
+ @Test
+ public void testIndexRowWithoutEmptyColumn() throws Exception {
+ if (async) {
+ // No need to run the same test twice one for async = true and the other for async = false
+ return;
+ }
+ long scn;
+ String dataTableName = generateUniqueName();
+ String indexTableName = generateUniqueName();
+ try (Connection conn = DriverManager.getConnection(getUrl())) {
+ populateTable(dataTableName); // with two rows ('a', 'ab', 'abc', 'abcd') and ('b', 'bc', 'bcd', 'bcde')
+ Thread.sleep(1000);
Review comment:
Sleep is not necessary. I forgot to remove it. Thank you for catching it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] kadirozde closed pull request #747: PHOENIX-5807 Index rows without empty column should be treated as unv…
Posted by GitBox <gi...@apache.org>.
kadirozde closed pull request #747: PHOENIX-5807 Index rows without empty column should be treated as unv…
URL: https://github.com/apache/phoenix/pull/747
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] gjacoby126 commented on a change in pull request #747: PHOENIX-5807 Index rows without empty column should be treated as unv…
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on a change in pull request #747: PHOENIX-5807 Index rows without empty column should be treated as unv…
URL: https://github.com/apache/phoenix/pull/747#discussion_r399897320
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java
##########
@@ -494,8 +476,7 @@ private boolean verifyRowAndRemoveEmptyColumn(List<Cell> cellList) throws IOExce
return true;
}
}
- byte[] rowKey = CellUtil.cloneRow(cell);
- return verifyRow(rowKey);
+ return false;
Review comment:
nit: comment to point out that empty column wasn't found so we're considering it unverified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] kadirozde commented on a change in pull request #747: PHOENIX-5807 Index rows without empty column should be treated as unv…
Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #747: PHOENIX-5807 Index rows without empty column should be treated as unv…
URL: https://github.com/apache/phoenix/pull/747#discussion_r399930336
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java
##########
@@ -494,8 +476,7 @@ private boolean verifyRowAndRemoveEmptyColumn(List<Cell> cellList) throws IOExce
return true;
}
}
- byte[] rowKey = CellUtil.cloneRow(cell);
- return verifyRow(rowKey);
+ return false;
Review comment:
Sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services