You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/21 11:21:20 UTC
[GitHub] [pulsar] RocMarshal opened a new pull request #14775: [hotfix] Remove unnecessary override methods
RocMarshal opened a new pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
Remove unnecessary override methods
### Modifications
Remove unnecessary override methods
### Verifying this change
This change is already covered by existing tests, such as *(please describe tests)*.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API: (yes / **no**)
- The schema: (yes / **no** / don't know)
- The default values of configurations: (yes / **no**)
- The wire protocol: (yes / **no**)
- The rest endpoints: (yes / **no**)
- The admin cli options: (yes / **no**)
- Anything that affects deployment: (yes / **no** / don't know)
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [x] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1086579541
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RocMarshal removed a comment on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
RocMarshal removed a comment on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1085478205
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RocMarshal commented on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1085478205
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1086766165
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RocMarshal commented on a change in pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#discussion_r839553756
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchemaImpl.java
##########
@@ -144,11 +144,6 @@ public String getTopicName() {
}
}
- @Override
Review comment:
@yuruguo Nice catch. Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RocMarshal commented on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1076502697
Hi, @eolivelli Would you mind helping to check it ? Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1086615187
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1086615187
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RocMarshal commented on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1086551456
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo merged pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
yuruguo merged pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1086562626
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RocMarshal removed a comment on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
RocMarshal removed a comment on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1084524765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1086579541
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1086589033
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1086766165
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RocMarshal removed a comment on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
RocMarshal removed a comment on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1076502697
Hi, @eolivelli Would you mind helping to check it ? Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#discussion_r838432658
##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchemaImpl.java
##########
@@ -144,11 +144,6 @@ public String getTopicName() {
}
}
- @Override
Review comment:
Can't this method be deleted?
Because [decode](https://github.com/apache/pulsar/pull/14775/files#diff-4ad4a66a312bd567cdb8ef7959da9bf77535425b17a49f21950c3b3fde105970L149)(line149) is implemented by `KeyValueSchemaImpl` instead of reusing the parent class implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RocMarshal commented on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1086798853
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RocMarshal commented on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1084524765
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RocMarshal commented on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
RocMarshal commented on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1085747296
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1086562626
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #14775: [hotfix] Remove unnecessary override methods
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #14775:
URL: https://github.com/apache/pulsar/pull/14775#issuecomment-1086589033
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org