You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "eren-terzioglu (via GitHub)" <gi...@apache.org> on 2023/09/07 08:12:32 UTC

[GitHub] [nuttx] eren-terzioglu opened a new pull request, #10521: xtensa/esp32s3: Add support to TWAI/CANBus controller

eren-terzioglu opened a new pull request, #10521:
URL: https://github.com/apache/nuttx/pull/10521

   ## Summary
   xtensa/esp32s3: Add support to TWAI/CANBus controller
   
   ## Impact
   Only ESP32S3
   
   ## Testing
   ESP32-S3 DevkitC-1 with using `esp32s3-devkit:twai` configuration and `can` example
   
   Note: I tested with `CAN loopback mode` under the `Device Drivers->CAN Driver Support` and wired CAN RX to CAN TX with a jumper cable (Default pins are pin 0 and pin 2).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] eren-terzioglu commented on pull request #10521: xtensa/esp32s3: Add support to TWAI/CANBus controller

Posted by "eren-terzioglu (via GitHub)" <gi...@apache.org>.
eren-terzioglu commented on PR #10521:
URL: https://github.com/apache/nuttx/pull/10521#issuecomment-1710086657

   > 
   
   New config normalized, thanks for the suggestion
   
   > @eren-terzioglu very well done!
   > 
   > Did you run: `$ ./tools/refresh.sh --silent --defaults all` to normalize the boards?
   > 
   > Seems like some boards are out of sync:
   > 
   > ```
   >   Normalize esp32s3-devkit/twai
   > 23,24d22
   > < CONFIG_ESP32S3_TWAI=y
   > < CONFIG_EXAMPLES_CAN=y
   > 26a25
   > > CONFIG_ESP32S3_TWAI=y
   > 27a27
   > > CONFIG_EXAMPLES_CAN=y
   > Saving the new configuration file
   > HEAD detached at pull/10521/merge
   > Changes not staged for commit:
   >   (use "git add <file>..." to update what will be committed)
   >   (use "git restore <file>..." to discard changes in working directory)
   > 	modified:   boards/xtensa/esp32s3/esp32s3-devkit/configs/twai/defconfig
   > ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] xiaoxiang781216 merged pull request #10521: xtensa/esp32s3: Add support to TWAI/CANBus controller

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10521:
URL: https://github.com/apache/nuttx/pull/10521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] acassis commented on pull request #10521: xtensa/esp32s3: Add support to TWAI/CANBus controller

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #10521:
URL: https://github.com/apache/nuttx/pull/10521#issuecomment-1709940816

   @eren-terzioglu very well done!
   
   Did you run: `$ ./tools/refresh.sh --silent --defaults all` to normalize the boards?
   
   Seems like some boards are out of sync:
   
   ```
     Normalize esp32s3-devkit/twai
   23,24d22
   < CONFIG_ESP32S3_TWAI=y
   < CONFIG_EXAMPLES_CAN=y
   26a25
   > CONFIG_ESP32S3_TWAI=y
   27a27
   > CONFIG_EXAMPLES_CAN=y
   Saving the new configuration file
   HEAD detached at pull/10521/merge
   Changes not staged for commit:
     (use "git add <file>..." to update what will be committed)
     (use "git restore <file>..." to discard changes in working directory)
   	modified:   boards/xtensa/esp32s3/esp32s3-devkit/configs/twai/defconfig
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org