You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/09/13 07:42:00 UTC

[GitHub] [incubator-shenyu] qicz opened a new pull request #2064: fix default fallback controller handler by "ShenyuResultWrap".

qicz opened a new pull request #2064:
URL: https://github.com/apache/incubator-shenyu/pull/2064


   the default fallback `DefaultFallbackController` uses the`DefaultShenyuEntity` that can not use custom `ShenyuResult`.  fixed it by `ShenyuResultWrap`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #2064: fix default fallback controller handler by "ShenyuResultWrap".

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2064:
URL: https://github.com/apache/incubator-shenyu/pull/2064#issuecomment-917941050


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2064?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2064](https://codecov.io/gh/apache/incubator-shenyu/pull/2064?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54f711e) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/53704ef8639d3b760c3e8466ae8e7f3a62ee1841?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53704ef) will **decrease** coverage by `0.21%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/2064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2064      +/-   ##
   ============================================
   - Coverage     60.83%   60.61%   -0.22%     
   - Complexity     4034     4037       +3     
   ============================================
     Files           606      608       +2     
     Lines         17833    17883      +50     
     Branches       1704     1707       +3     
   ============================================
   - Hits          10848    10840       -8     
   - Misses         6110     6165      +55     
   - Partials        875      878       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...shenyu/web/fallback/DefaultFallbackController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9mYWxsYmFjay9EZWZhdWx0RmFsbGJhY2tDb250cm9sbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `72.41% <0.00%> (-13.80%)` | :arrow_down: |
   | [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `81.55% <0.00%> (-7.77%)` | :arrow_down: |
   | [...apache/shenyu/admin/controller/RoleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9Sb2xlQ29udHJvbGxlci5qYXZh) | `87.50% <0.00%> (ø)` | |
   | [...apache/shenyu/admin/controller/RuleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SdWxlQ29udHJvbGxlci5qYXZh) | `100.00% <0.00%> (ø)` | |
   | [...ache/shenyu/admin/controller/PluginController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5Db250cm9sbGVyLmphdmE=) | `100.00% <0.00%> (ø)` | |
   | [...che/shenyu/admin/controller/AppAuthController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9BcHBBdXRoQ29udHJvbGxlci5qYXZh) | `100.00% <0.00%> (ø)` | |
   | [...he/shenyu/admin/controller/MetaDataController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9NZXRhRGF0YUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | |
   | [...he/shenyu/admin/controller/ResourceController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SZXNvdXJjZUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | |
   | [...he/shenyu/admin/controller/SelectorController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TZWxlY3RvckNvbnRyb2xsZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2064?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2064?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb6ff9d...54f711e](https://codecov.io/gh/apache/incubator-shenyu/pull/2064?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] yu199195 merged pull request #2064: fix default fallback controller handler by "ShenyuResultWrap".

Posted by GitBox <gi...@apache.org>.
yu199195 merged pull request #2064:
URL: https://github.com/apache/incubator-shenyu/pull/2064


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2064: fix default fallback controller handler by "ShenyuResultWrap".

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2064:
URL: https://github.com/apache/incubator-shenyu/pull/2064#issuecomment-917941050


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2064?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2064](https://codecov.io/gh/apache/incubator-shenyu/pull/2064?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (54f711e) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/53704ef8639d3b760c3e8466ae8e7f3a62ee1841?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53704ef) will **decrease** coverage by `0.21%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/2064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2064      +/-   ##
   ============================================
   - Coverage     60.83%   60.61%   -0.22%     
   - Complexity     4034     4037       +3     
   ============================================
     Files           606      608       +2     
     Lines         17833    17883      +50     
     Branches       1704     1707       +3     
   ============================================
   - Hits          10848    10840       -8     
   - Misses         6110     6165      +55     
   - Partials        875      878       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2064?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...shenyu/web/fallback/DefaultFallbackController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9mYWxsYmFjay9EZWZhdWx0RmFsbGJhY2tDb250cm9sbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...yu/sync/data/http/refresh/AbstractDataRefresh.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvcmVmcmVzaC9BYnN0cmFjdERhdGFSZWZyZXNoLmphdmE=) | `72.41% <0.00%> (-13.80%)` | :arrow_down: |
   | [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `81.55% <0.00%> (-7.77%)` | :arrow_down: |
   | [...apache/shenyu/admin/controller/RoleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9Sb2xlQ29udHJvbGxlci5qYXZh) | `87.50% <0.00%> (ø)` | |
   | [...apache/shenyu/admin/controller/RuleController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SdWxlQ29udHJvbGxlci5qYXZh) | `100.00% <0.00%> (ø)` | |
   | [...ache/shenyu/admin/controller/PluginController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9QbHVnaW5Db250cm9sbGVyLmphdmE=) | `100.00% <0.00%> (ø)` | |
   | [...che/shenyu/admin/controller/AppAuthController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9BcHBBdXRoQ29udHJvbGxlci5qYXZh) | `100.00% <0.00%> (ø)` | |
   | [...he/shenyu/admin/controller/MetaDataController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9NZXRhRGF0YUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | |
   | [...he/shenyu/admin/controller/ResourceController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9SZXNvdXJjZUNvbnRyb2xsZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | |
   | [...he/shenyu/admin/controller/SelectorController.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vY29udHJvbGxlci9TZWxlY3RvckNvbnRyb2xsZXIuamF2YQ==) | `100.00% <0.00%> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2064/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2064?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2064?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cb6ff9d...54f711e](https://codecov.io/gh/apache/incubator-shenyu/pull/2064?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org