[GitHub] [flink] XComp commented on a diff in pull request #19597: [FLINK-27431][rpc] Allow RpcTimeouts to be specified as Duration

[GitBox <gi...@apache.org>]

XComp commented on code in PR #19597:
URL: https://github.com/apache/flink/pull/19597#discussion_r860527912


##########
flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/TimeoutCallStackTest.java:
##########
@@ -77,9 +79,19 @@ void stopTestEndpoints() {
 
     @Test
     void testTimeoutException() throws Exception {

Review Comment:
   ```suggestion
       void testTimeoutExceptionWithTime() throws Exception {
   ```
   nit: Can we make this test as descriptive as the other one?



##########
flink-rpc/flink-rpc-akka/src/test/java/org/apache/flink/runtime/rpc/akka/TimeoutCallStackTest.java:
##########
@@ -77,9 +79,19 @@ void stopTestEndpoints() {
 
     @Test
     void testTimeoutException() throws Exception {
+        txestTimeoutException(gateway -> gateway.callThatTimesOut(Time.milliseconds(1)));
+    }
+
+    @Test
+    void testTimeoutExceptionWithDuration() throws Exception {
+        txestTimeoutException(gateway -> gateway.callThatTimesOut(Duration.ofMillis(1)));
+    }
+
+    private void txestTimeoutException(

Review Comment:
   ```suggestion
       private void testTimeoutException(
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org