[GitHub] maropu commented on a change in pull request #23783: [SPARK-26854][SQL] Support ANY/SOME subquery

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #23783: [SPARK-26854][SQL] Support ANY/SOME subquery
URL: https://github.com/apache/spark/pull/23783#discussion_r256713703
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ##########
 @@ -1477,12 +1477,12 @@ class Analyzer(
           resolveSubQuery(s, plans)(ScalarSubquery(_, _, exprId))
         case e @ Exists(sub, _, exprId) if !sub.resolved =>
           resolveSubQuery(e, plans)(Exists(_, _, exprId))
-        case InSubquery(values, l @ ListQuery(_, _, exprId, _))
+        case p @SubqueryPredicate(values, comparison, l @ ListQuery(_, _, exprId, _))
 
 Review comment:
   nit: need a space after `@`. Also, could you check other code style along with the other formats? I found some style errors.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org