You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/09/19 08:00:25 UTC

[GitHub] [ozone] adoroszlai opened a new pull request, #5318: HDDS-9302. Summarize failures of acceptance/kubernetes checks

adoroszlai opened a new pull request, #5318:
URL: https://github.com/apache/ozone/pull/5318

   ## What changes were proposed in this pull request?
   
   Acceptance and kubernetes CI checks provide HTML-based report from Robot as summary, which is great for checking locally.  This PR adds a text-based summary so that we can give a quick overview in the Github Actions UI.
   
   https://issues.apache.org/jira/browse/HDDS-9302
   
   ## How was this patch tested?
   
   Tested in CI.
   
   Failed acceptance run:
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/6224728553/job/16894469092#step:6:1
   
   Successful acceptance run:
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/6224728553/job/16894468903#step:6:1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #5318: HDDS-9302. Summarize failures of acceptance/kubernetes checks

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5318:
URL: https://github.com/apache/ozone/pull/5318#issuecomment-1730119420

   Thanks @aswinshakil for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on a diff in pull request #5318: HDDS-9302. Summarize failures of acceptance/kubernetes checks

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #5318:
URL: https://github.com/apache/ozone/pull/5318#discussion_r1333460325


##########
.github/workflows/ci.yml:
##########
@@ -306,6 +309,9 @@ jobs:
           sudo mkdir .aws && sudo chmod 777 .aws && sudo chown 1000 .aws
           popd
           ./hadoop-ozone/dev-support/checks/kubernetes.sh
+      - name: Summary of failures
+        run: cat target/${{ github.job }}/summary.txt
+        if: ${{ !cancelled() }}

Review Comment:
   Thanks @aswinshakil for pointing this out.  Patch is updated, can you please take another look?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on a diff in pull request #5318: HDDS-9302. Summarize failures of acceptance/kubernetes checks

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #5318:
URL: https://github.com/apache/ozone/pull/5318#discussion_r1332337391


##########
.github/workflows/ci.yml:
##########
@@ -306,6 +309,9 @@ jobs:
           sudo mkdir .aws && sudo chmod 777 .aws && sudo chown 1000 .aws
           popd
           ./hadoop-ozone/dev-support/checks/kubernetes.sh
+      - name: Summary of failures
+        run: cat target/${{ github.job }}/summary.txt
+        if: ${{ !cancelled() }}

Review Comment:
   Right, it should be.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] aswinshakil commented on a diff in pull request #5318: HDDS-9302. Summarize failures of acceptance/kubernetes checks

Posted by "aswinshakil (via GitHub)" <gi...@apache.org>.
aswinshakil commented on code in PR #5318:
URL: https://github.com/apache/ozone/pull/5318#discussion_r1332260890


##########
.github/workflows/ci.yml:
##########
@@ -306,6 +309,9 @@ jobs:
           sudo mkdir .aws && sudo chmod 777 .aws && sudo chown 1000 .aws
           popd
           ./hadoop-ozone/dev-support/checks/kubernetes.sh
+      - name: Summary of failures
+        run: cat target/${{ github.job }}/summary.txt
+        if: ${{ !cancelled() }}

Review Comment:
   I have a quick question, why is it that for integration test we use
   ```
         - name: Summary of failures
           run: cat target/${{ github.job }}/summary.txt
           if: always()
   ```
   Shouldn't that also be only if the job is not canceled? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai merged pull request #5318: HDDS-9302. Summarize failures of acceptance/kubernetes checks

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5318:
URL: https://github.com/apache/ozone/pull/5318


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org