You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jo...@apache.org on 2020/06/05 23:01:53 UTC

[impala] 02/02: Filter out "Checksum validation failed" messages during the maven build

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 03f2b559c31af7fc11165cf3b00876900e234663
Author: Joe McDonnell <jo...@cloudera.com>
AuthorDate: Fri Apr 17 19:20:53 2020 -0700

    Filter out "Checksum validation failed" messages during the maven build
    
    Some Impala dependencies come from repositories that don't have
    checksums available. During the build, this produces a large
    number of messages like:
    [WARNING] Checksum validation failed, no checksums available from the repository for ...
    or:
    [WARNING] Checksum validation failed, could not read expected checksum ...
    These messages are not very useful, and they make it harder to search
    the console output for failed tests. This filters them out of the maven
    output. Differet versions of maven structure the messsages differently,
    so this filters all the "Checksum validation failed" messages that happen
    at WARNING level.
    
    Testing:
     - Ran core tests, verified the messages are gone
    
    Change-Id: I19afbd157533e52ef3157730c7ec5159241749bc
    Reviewed-on: http://gerrit.cloudera.org:8080/15775
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
    Reviewed-by: Anurag Mantripragada <an...@cloudera.com>
---
 bin/mvn-quiet.sh | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/bin/mvn-quiet.sh b/bin/mvn-quiet.sh
index f782ff4..c7c557e 100755
--- a/bin/mvn-quiet.sh
+++ b/bin/mvn-quiet.sh
@@ -34,10 +34,16 @@ EOF
 LOGGING_OPTIONS="-Dorg.slf4j.simpleLogger.showDateTime \
   -Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss"
 
+# Filter out "Checksum validation failed" messages, as they are mostly harmless and
+# make it harder to search for failed tests in the console output. Limit the filtering
+# to WARNING messages.
+CHECKSUM_VALIDATION_FAILED_REGEX="[WARNING].*Checksum validation failed"
+
 # Always use maven's batch mode (-B), as it produces output that is easier to parse.
 if ! mvn -B $IMPALA_MAVEN_OPTIONS $LOGGING_OPTIONS "$@" | \
   tee -a "$LOG_FILE" | \
-  grep -E -e WARNING -e ERROR -e SUCCESS -e FAILURE -e Test -e "Found Banned"; then
+  grep -E -e WARNING -e ERROR -e SUCCESS -e FAILURE -e Test -e "Found Banned" | \
+  grep -v -i "${CHECKSUM_VALIDATION_FAILED_REGEX}"; then
   echo "mvn $IMPALA_MAVEN_OPTIONS $@ exited with code $?"
   exit 1
 fi