[GitHub] [maven-fluido-skin] slawekjaranowski commented on a diff in pull request #33: rework ITs to better integrate into skin documentation

[GitBox <gi...@apache.org>]

slawekjaranowski commented on code in PR #33:
URL: https://github.com/apache/maven-fluido-skin/pull/33#discussion_r890615352


##########
src/site/site.xml:
##########
@@ -27,9 +27,7 @@ under the License.
   <skin>
     <groupId>org.apache.maven.skins</groupId>
     <artifactId>maven-fluido-skin</artifactId>
-    <!-- TODO check with next parent, and next m-site-p -->
-    <!-- <version>${project.version}</version> -->
-    <version>1.10.0</version>
+    <version>${project.version}</version><!-- keep using current version, even if it implies running mvn -Prun-its,reporting install site -->
   </skin>

Review Comment:
   We have IT test which use current build skins.
   
   IMHO project should used latest release version - even more we have the same definition in parent and we needn't here it.
   
   all project should be build by the same standard command



##########
src/site/site.xml:
##########
@@ -27,9 +27,7 @@ under the License.
   <skin>
     <groupId>org.apache.maven.skins</groupId>
     <artifactId>maven-fluido-skin</artifactId>
-    <!-- TODO check with next parent, and next m-site-p -->
-    <!-- <version>${project.version}</version> -->
-    <version>1.10.0</version>
+    <version>${project.version}</version><!-- keep using current version, even if it implies running mvn -Prun-its,reporting install site -->
   </skin>

Review Comment:
   We have IT test which use current build skins.
   
   IMHO project should used latest release version - even more we have the same definition in parent and we needn't here it.
   
   all project should be build by the same standard command



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org