You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/05 18:23:36 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request, #6704: server: fix volume migration on user vm scale
shwstppr opened a new pull request, #6704:
URL: https://github.com/apache/cloudstack/pull/6704
### Description
Fixes #6701
When volume migration is initiated by system account check is not needed.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [x] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1289086589
> Moving this to draft, need to revisit this later. Ideally, the normal user should not be allowed to scale VM or change volume offering with volume migration.
@shwstppr , what if a provider has zones in different legal entities (USA vs EU)? they would want to allow a user to move data from one to the other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1280251351
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6704)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6704&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6704&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6704&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_coverage&view=list) [2.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1325216003
@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1283323791
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1280219620
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1280304998
@harikrishna-patnala a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1299696497
This PR is all good except for the failure of the new smoke test on simulator and xenserver. I'll fix that and then this will be ready for merge. @rohityadavcloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1275678184
> @DaanHoogland didn't understand you. I was saying scale VM operation shouldn't be allowed _with migration of volume_ and without migration it should be fine. This was based on the fact that by default user role is not allowed to use `migrateVolume` API.
ok, makes sense, migration not being allowed. sorry I misunderstood.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1282052086
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1282048389
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1323522739
@soreana Hi, PR should be good for testing. There are a couple of failures for Xenserver and Simulator which I feel are more related to the test itself and not the backend functionality. I'll be adding a fix for them later today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1237374732
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1237450768
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6704?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6704](https://codecov.io/gh/apache/cloudstack/pull/6704?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ce956b8) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/c290cbcb71e80910c4ef22149803d758f13afbc6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c290cbc) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 4.17 #6704 +/- ##
=========================================
Coverage 5.87% 5.88%
+ Complexity 3928 3926 -2
=========================================
Files 2451 2451
Lines 242312 242314 +2
Branches 37920 37920
=========================================
+ Hits 14239 14251 +12
+ Misses 226499 226488 -11
- Partials 1574 1575 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6704?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...in/java/com/cloud/server/ManagementServerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6704/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3NlcnZlci9NYW5hZ2VtZW50U2VydmVySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/com/cloud/storage/VolumeApiServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6704/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvVm9sdW1lQXBpU2VydmljZUltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6704/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3ZtL1VubWFuYWdlZFZNc01hbmFnZXJJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/6704/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `56.49% <0.00%> (-2.26%)` | :arrow_down: |
| [.../network/lb/InternalLoadBalancerVMManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6704/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2ludGVybmFsLWxvYWRiYWxhbmNlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9uZXR3b3JrL2xiL0ludGVybmFsTG9hZEJhbGFuY2VyVk1NYW5hZ2VySW1wbC5qYXZh) | `25.05% <0.00%> (+0.46%)` | :arrow_up: |
| [.../org/apache/cloudstack/ldap/LdapAuthenticator.java](https://codecov.io/gh/apache/cloudstack/pull/6704/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy91c2VyLWF1dGhlbnRpY2F0b3JzL2xkYXAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbGRhcC9MZGFwQXV0aGVudGljYXRvci5qYXZh) | `23.91% <0.00%> (+0.72%)` | :arrow_up: |
| [...rc/main/java/com/cloud/deploy/FirstFitPlanner.java](https://codecov.io/gh/apache/cloudstack/pull/6704/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2RlcGxveS9GaXJzdEZpdFBsYW5uZXIuamF2YQ==) | `28.09% <0.00%> (+0.82%)` | :arrow_up: |
| [...loudstack/server/auth/PBKDF2UserAuthenticator.java](https://codecov.io/gh/apache/cloudstack/pull/6704/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy91c2VyLWF1dGhlbnRpY2F0b3JzL3Bia2RmMi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9zZXJ2ZXIvYXV0aC9QQktERjJVc2VyQXV0aGVudGljYXRvci5qYXZh) | `51.78% <0.00%> (+1.78%)` | :arrow_up: |
| [...oud/server/auth/SHA256SaltedUserAuthenticator.java](https://codecov.io/gh/apache/cloudstack/pull/6704/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy91c2VyLWF1dGhlbnRpY2F0b3JzL3NoYTI1NnNhbHRlZC9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zZXJ2ZXIvYXV0aC9TSEEyNTZTYWx0ZWRVc2VyQXV0aGVudGljYXRvci5qYXZh) | `69.09% <0.00%> (+1.81%)` | :arrow_up: |
| [...pper/LibvirtPrepareForMigrationCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/6704/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0UHJlcGFyZUZvck1pZ3JhdGlvbkNvbW1hbmRXcmFwcGVyLmphdmE=) | `53.19% <0.00%> (+2.12%)` | :arrow_up: |
| ... and [6 more](https://codecov.io/gh/apache/cloudstack/pull/6704/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1280218840
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1281176442
<b>Trillian test result (tid-5143)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40761 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6704-t5143-vmware-65u2.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_scale_vm_dont_allow_disk_offering_change | `Error` | 0.11 | test_scale_vm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1282051039
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1299676186
@shwstppr @DaanHoogland @harikrishna-patnala any update on this, is this ready for review/testing? cc @NuxRo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1323732078
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6704)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6704&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6704&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6704&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_coverage&view=list) [1.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1237405847
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1237405688
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1280220323
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1282162423
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1330471621
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
soreana commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1326862720
I've tested this pr, wiith this patch, I can scale the VM as a domain admin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1327172045
Test LGTM
@borisstoyanov @vladimirpetrov can you help test this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1326884403
<b>Trillian test result (tid-5259)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37792 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6704-t5259-xenserver-71.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 622.38 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1325035162
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1330327931
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1330471371
env issue - pkg is okay for EL7 and others (will rekick after smoketests)
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1331452218
<b>Trillian test result (tid-5285)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42784 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6704-t5285-kvm-centos7.zip
Smoke tests completed. 101 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1237374598
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1280220871
Added a new global setting for scale VM operation "allow.diskOffering.change.during.scale.vm" which determines whether to allow or disallow disk offering change for root volume during scaling of a stopped or running VM. By default it is false, which means disk offering change will not happen during scale VM. This is to keep the old behavior as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1274494883
> Moving this to draft, need to revisit this later. Ideally, the normal user should not be allowed to scale VM or change volume offering with volume migration.
is ther some technical reason not to allow that @shwstppr ? because from a business point of view I would want them to be able to scale VMs and volumes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1280273215
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1280312564
<b>Trillian Build Failed (tid-5141)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1279004257
<b>Trillian Build Failed (tid-5131)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1299883347
@harikrishna-patnala
> This PR is all good except for the failure of the new smoke test on simulator and xenserver. I'll fix that and then this will be ready for merge. @rohityadavcloud
it fails on simulator as well (in travis)
```
=== TestName: test_05_scale_vm_dont_allow_disk_offering_change | Status : FAILED ===
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1237404087
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6704)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6704&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6704&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6704&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on code in PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#discussion_r1033519440
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1823,6 +1823,26 @@ private Volume changeDiskOfferingForVolumeInternal(VolumeVO volume, Long newDisk
return volume;
}
+ /**
+ * This method is to compare long values, in miniops and maxiops a or b can be null or 0.
+ * Use this method to treat 0 and null as same
+ *
+ * @param a
+ * @param b
+ * @return true if a and b are equal excluding 0 and null values.
+ */
+ private boolean compareEqualsIncludingNullOrZero(Long a, Long b) {
+ if ((a != null && a == 0 && b == null) || (a == null && b != null && b == 0)) {
+ return true;
+ }
+
+ if (a == b) {
+ return true;
+ }
+
+ return false;
+ }
Review Comment:
We could moved this method to `NumbersUtils` and add unit tests.
As zero and null will be considered the same, we can simplify the code:
`org.apache.commons.lang3.ObjectUtils`
```suggestion
private boolean compareEqualsIncludingNullOrZero(Long a, Long b) {
a = ObjectUtils.defaultIfNull(a, 0L);
b = ObjectUtils.defaultIfNull(b, 0L);
return a.equals(b);
}
```
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1823,6 +1823,26 @@ private Volume changeDiskOfferingForVolumeInternal(VolumeVO volume, Long newDisk
return volume;
}
+ /**
+ * This method is to compare long values, in miniops and maxiops a or b can be null or 0.
+ * Use this method to treat 0 and null as same
+ *
+ * @param a
+ * @param b
+ * @return true if a and b are equal excluding 0 and null values.
+ */
+ private boolean compareEqualsIncludingNullOrZero(Long a, Long b) {
+ if ((a != null && a == 0 && b == null) || (a == null && b != null && b == 0)) {
+ return true;
+ }
+
+ if (a == b) {
+ return true;
+ }
+
+ return false;
+ }
Review Comment:
We could move this method to `NumbersUtils` and add unit tests.
As zero and null will be considered the same, we can simplify the code:
`org.apache.commons.lang3.ObjectUtils`
```suggestion
private boolean compareEqualsIncludingNullOrZero(Long a, Long b) {
a = ObjectUtils.defaultIfNull(a, 0L);
b = ObjectUtils.defaultIfNull(b, 0L);
return a.equals(b);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1326891580
<b>Trillian test result (tid-5261)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39341 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6704-t5261-vmware-65u2.zip
Smoke tests completed. 101 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1237729985
<b>Trillian test result (tid-4820)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40069 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6704-t4820-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 604.34 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1238056686
Moving this to draft, need to revisit this later. Ideally, the normal user should not be allowed to scale VM or change volume offering with volume migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1331739520
I've committed suggestions, there's one outstanding on refactoring to a utils which can be done in a separate PR as #shwstppr is on holiday this week. I'll merge this to keep effort on-going for 4.17.2.0 release.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1326372175
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1325215236
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1280304733
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1280320359
<b>Trillian Build Failed (tid-5142)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1282230669
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1282185508
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#discussion_r1035602367
##########
server/src/main/java/com/cloud/vm/UserVmManager.java:
##########
@@ -47,9 +47,12 @@
*/
public interface UserVmManager extends UserVmService {
String EnableDynamicallyScaleVmCK = "enable.dynamic.scale.vm";
+ String AllowDiskOfferingChangeDuringScaleVmCK = "allow.diskOffering.change.during.scale.vm";
Review Comment:
```suggestion
String AllowDiskOfferingChangeDuringScaleVmCK = "allow.diskoffering.change.during.scale.vm";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1331740069
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1330237287
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on code in PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#discussion_r1034683565
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1823,6 +1824,21 @@ private Volume changeDiskOfferingForVolumeInternal(VolumeVO volume, Long newDisk
return volume;
}
+ /**
+ * This method is to compare long values, in miniops and maxiops a or b can be null or 0.
+ * Use this method to treat 0 and null as same
+ *
+ * @param a
+ * @param b
+ * @return true if a and b are equal excluding 0 and null values.
+ */
+ private boolean compareEqualsIncludingNullOrZero(Long a, Long b) {
+ a = ObjectUtils.defaultIfNull(a, 0L);
+ b = ObjectUtils.defaultIfNull(b, 0L);
+
+ return a.equals(b);
+ }
Review Comment:
@shwstppr, we could move this method to `com.cloud.utils.NumbersUtils` and add some unit tests.
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1823,6 +1824,21 @@ private Volume changeDiskOfferingForVolumeInternal(VolumeVO volume, Long newDisk
return volume;
}
+ /**
+ * This method is to compare long values, in miniops and maxiops a or b can be null or 0.
+ * Use this method to treat 0 and null as same
+ *
+ * @param a
+ * @param b
+ * @return true if a and b are equal excluding 0 and null values.
+ */
+ private boolean compareEqualsIncludingNullOrZero(Long a, Long b) {
Review Comment:
@shwstppr, what do you think about renaming the method to `compareLongsDefaultingNullToZero`?
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -2036,7 +2036,14 @@ private void validateDiskOfferingChecks(ServiceOfferingVO currentServiceOffering
}
}
- private void changeDiskOfferingForRootVolume(Long vmId, DiskOfferingVO newDiskOffering, Map<String, String> customParameters) throws ResourceAllocationException {
+ private void changeDiskOfferingForRootVolume(Long vmId, DiskOfferingVO newDiskOffering, Map<String, String> customParameters, Long zoneId) throws ResourceAllocationException {
+
+ if (!AllowDiskOfferingChangeDuringScaleVm.valueIn(zoneId)) {
+ if (s_logger.isDebugEnabled()) {
+ s_logger.debug(String.format("Disk Offering change for the root volume is disabled during the compute offering change operation. Please check the setting %s", AllowDiskOfferingChangeDuringScaleVm.key()));
Review Comment:
```suggestion
s_logger.debug(String.format("Changing the disk offering of the root volume during the compute offering change operation is disabled. Please check the setting [%s].", AllowDiskOfferingChangeDuringScaleVm.key()));
```
##########
server/src/main/java/com/cloud/vm/UserVmManager.java:
##########
@@ -47,9 +47,12 @@
*/
public interface UserVmManager extends UserVmService {
String EnableDynamicallyScaleVmCK = "enable.dynamic.scale.vm";
+ String AllowDiskOfferingChangeDuringScaleVmCK = "allow.diskOffering.change.during.scale.vm";
String AllowUserExpungeRecoverVmCK ="allow.user.expunge.recover.vm";
ConfigKey<Boolean> EnableDynamicallyScaleVm = new ConfigKey<Boolean>("Advanced", Boolean.class, EnableDynamicallyScaleVmCK, "false",
"Enables/Disables dynamically scaling a vm", true, ConfigKey.Scope.Zone);
+ ConfigKey<Boolean> AllowDiskOfferingChangeDuringScaleVm = new ConfigKey<Boolean>("Advanced", Boolean.class, AllowDiskOfferingChangeDuringScaleVmCK, "false",
+ "Determines whether to allow or disallow disk offering change for root volume during scaling of a stopped or running vm", true, ConfigKey.Scope.Zone);
Review Comment:
I think we could remove the `String` variable:
```suggestion
String AllowUserExpungeRecoverVmCK ="allow.user.expunge.recover.vm";
ConfigKey<Boolean> EnableDynamicallyScaleVm = new ConfigKey<Boolean>("Advanced", Boolean.class, EnableDynamicallyScaleVmCK, "false",
"Enables/Disables dynamically scaling a vm", true, ConfigKey.Scope.Zone);
ConfigKey<Boolean> AllowDiskOfferingChangeDuringScaleVm = new ConfigKey<Boolean>("Advanced", Boolean.class, "allow.diskOffering.change.during.scale.vm", "false",
"Determines whether to allow or disallow disk offering change for root volume during scaling of a stopped or running vm", true, ConfigKey.Scope.Zone);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1237397839
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1282186137
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1280219724
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1283324482
@harikrishna-patnala a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1284068628
<b>Trillian test result (tid-5163)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39579 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6704-t5163-xenserver-71.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_scale_vm_dont_allow_disk_offering_change | `Error` | 0.11 | test_scale_vm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1282049580
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1282065947
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6704 (SL-JID-2528)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
soreana commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1323497710
@shwstppr Can you give an update about this PR, please? What is the current status? I'm willing to help if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
soreana commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1323551587
@shwstppr That sounds great, thank you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1282148548
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6704)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6704&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6704&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6704&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=CODE_SMELL) [11 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6704&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_coverage&view=list) [1.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6704&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1280230994
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6704 (SL-JID-2517)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#discussion_r999054284
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1823,6 +1823,26 @@ private Volume changeDiskOfferingForVolumeInternal(VolumeVO volume, Long newDisk
return volume;
}
+ /**
+ * This method is to compare long values, in miniops and maxiops a or b can be null or 0.
+ * Use this method to treat 0 and null as same
+ *
+ * @param a
+ * @param b
+ * @return true if a and b are equal excluding 0 and null values.
+ */
+ private boolean compareEqualsIncludingNullOrZero(Long a, Long b) {
+ if ((a != null && a == 0 && b == null) || (a == null && b != null && b == 0)) {
+ return true;
+ }
+
+ if (a == b) {
Review Comment:
```suggestion
if (a.equals(b)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1284158990
<b>Trillian test result (tid-5165)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43308 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6704-t5165-vmware-65u2.zip
Smoke tests completed. 100 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 644.83 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1331772918
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1330236604
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1289491505
@DaanHoogland migration behaviour can now be tweaked with new global setting added by @harikrishna-patnala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1325034507
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1325158705
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1326372651
@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1326892980
<b>Trillian test result (tid-5260)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39425 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6704-t5260-kvm-centos7.zip
Smoke tests completed. 101 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1274504427
@DaanHoogland didn't understand you.
I was saying scale VM operation shouldn't be allowed *with migration of volume* and without migration it should be fine.
This was based on the fact that by default user role is not allowed to use `migrateVolume` API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6704: server: fix volume migration on user vm scale
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6704:
URL: https://github.com/apache/cloudstack/pull/6704#issuecomment-1279645402
<b>Trillian Build Failed (tid-5137)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org