You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Eric Charles (JIRA)" <se...@james.apache.org> on 2013/04/26 14:46:17 UTC

[jira] [Closed] (IMAP-372) Deadlock in AbstractDelegatingMailboxListener under load

     [ https://issues.apache.org/jira/browse/IMAP-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Charles closed IMAP-372.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 0.3

Patch is working fine here, so I have committed to trunk.
Closing this JIRA. If we identify any side-effect, we will reopen it,

                
> Deadlock in AbstractDelegatingMailboxListener under load
> --------------------------------------------------------
>
>                 Key: IMAP-372
>                 URL: https://issues.apache.org/jira/browse/IMAP-372
>             Project: James Imap
>          Issue Type: Bug
>          Components: Mailbox
>            Reporter: Andrzej Rusin
>            Assignee: Eric Charles
>             Fix For: 0.3
>
>         Attachments: james-listener-deadlock-2.txt, James Listener Deadlock.txt
>
>
> In AbstractDelegatingMailboxListener::event, firing the events inside the synchronized blocks causes a deadlock involving:
> lock on HashMapDelegatingMailboxListener::listeners
> (synchronized methods) lock on SelectedMailboxImpl
> In my example, these 3 methods got interlocked:
> AbstractDelegatingMailboxListener.addListener
> SelectedMailboxImpl.msn
> AbstractDelegatingMailboxListener.removeListener
> My idea to fix it is basically to take the for loop on mListeners outside the synchronized block in org.apache.james.mailbox.store.AbstractDelegatingMailboxListener.event(Event). That will not make the propagated event processing in SelectedMailboxImpl hit the synchronized lock on listeners.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org