[jira] [Comment Edited] (OFBIZ-6360) Form widget rendering broken for EmailServices.java

["Christian Carlow (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542387#comment-14542387 ] 

Christian Carlow edited comment on OFBIZ-6360 at 5/13/15 6:35 PM:
------------------------------------------------------------------

This patch causes HtmlScreenRenderer.renderScreenletSubWidget() to create a HtmlFormRenderer object and map it to context.formStringRenderer when it doesn't already exist which is the case for EmailServices.java since no request variable ever exists.

Form widget button rendering required patching also because it depends on the request parameter.  The patch allows them to resolve but might need more work such as controlling the link hrefs (right now Evolution expands to mail://local/catalog/control/EditProduct).

Also included in the patch is the HtmlFormRenderer.renderFormatHeaderOpen and renderFormatHeaderClose methods of the depended upon issue OFBIZ-6354.


was (Author: ofbizzer):
This patch causes HtmlScreenRenderer.renderScreenletSubWidget() to create a HtmlFormRenderer object and map it to context.formStringRenderer when it doesn't already exist which is the case for EmailServices.java since no request variable ever exists.

Form widget button rendering required patching also because it depends on the request parameter.  The patch allows them to resolve but might need more work such as controlling the link hrefs (right now Evolution expands to mail://local/catalog/control/EditProduct).

Also included in the patch is the HtmlFormRenderer.renderFormatHeaderOpen and renderFormatHeaderClose methods of the dependent issue OFBIZ-6354.

> Form widget rendering broken for EmailServices.java
> ---------------------------------------------------
>
>                 Key: OFBIZ-6360
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6360
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Christian Carlow
>             Fix For: Trunk
>
>         Attachments: OFBIZ-6360.patch
>
>
> Currently only FTL files are rendered by EmailServices.java because formStringRenderer is null for HtmlScreenRenderer.java#renderScreenletSubWidget which is supposed to be extracted from the context parameter, previously from the request parameter, which never exists for the emailing service.  This issue was encountered when testing the sendQuoteReportMail service for the form widget that replaced the FTL for OFBIZ-6349.  
> EmailServices.java is still using the deprecated HtmlScreenRenderer and FoScreenRenderer which should both be replaced by MacroScreenRenderer.  This made me realize I left out the new header rendering functionality for patch OFBIZ-6354 for these two deprecated classes which probably need to be provided along with the existing patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)