You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2020/07/15 10:23:18 UTC

[Bug 7840] New: description exists for non-existent rule USER_IN_WELCOMELIST_TO

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7840

            Bug ID: 7840
           Summary: description exists for non-existent rule
                    USER_IN_WELCOMELIST_TO
           Product: Spamassassin
           Version: 3.4.2
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Rules
          Assignee: dev@spamassassin.apache.org
          Reporter: waschtl@sbronner.com
  Target Milestone: Undefined

Almost all instances of USER_IN_WELCOMELIST_TO are conditional, but not the
translations of the description:

30_text_de.cf:335
30_text_fr.cf:254
30_text_pl.cf:240
30_text_pt_br.cf:57

This causes the configuration parser to emit a warning. And that, in turn,
causes sa-update to abort.

See also the ongoing discussion in #7826.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7840] description exists for non-existent rule USER_IN_WELCOMELIST_TO

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7840

Kevin A. McGrail <km...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Kevin A. McGrail <km...@apache.org> ---
OK, this should be fixed with the next rules publication with this commit
included.  

svn commit -m 'Much cleaner to keep one rule name but use a if condition to set
which eval is called.  This fixes bug 7840'
Sending        rules/50_scores.cf
Sending        rules/60_whitelist.cf
Transmitting file data ..
Committed revision 1879885.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7840] description exists for non-existent rule USER_IN_WELCOMELIST_TO

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7840

Kevin A. McGrail <km...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #3 from Kevin A. McGrail <km...@apache.org> ---
This issue only happens with 3.4.2 and before where a lint warning causes a
failure.

Recommend updating but I'm working on a fix with rules.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7840] description exists for non-existent rule USER_IN_WELCOMELIST_TO

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7840

yannik@sembritzki.me changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yannik@sembritzki.me

--- Comment #6 from yannik@sembritzki.me ---
SA 3.4.2 is the latest version available on debian stable (buster). 

Therefore this version is probably in use by many people.

I just tried sa-update, but it still fails:

$ date
Fr 17. Jul 11:27:35 CEST 2020
$ sa-update -v
Update available for channel updates.spamassassin.org: 1879434 -> 1879882
http: (curl) GET http://sa-update.razx.cloud/1879882.tar.gz, success
http: (curl) GET http://sa-update.razx.cloud/1879882.tar.gz.sha512, success
http: (curl) GET http://sa-update.razx.cloud/1879882.tar.gz.sha256, success
http: (curl) GET http://sa-update.razx.cloud/1879882.tar.gz.asc, success
config: warning: description exists for non-existent rule
USER_IN_WELCOMELIST_TO

channel: lint check of update failed, channel failed
Update failed, exiting with code 4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7840] description exists for non-existent rule USER_IN_WELCOMELIST_TO

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7840

--- Comment #11 from Sebastian J. Bronner <wa...@sbronner.com> ---
Yes. I can confirm the absence of a warning as well as a successuful sa-update
run.

Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7840] description exists for non-existent rule USER_IN_WELCOMELIST_TO

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7840

--- Comment #5 from Kevin A. McGrail <km...@apache.org> ---
I believe ruleset 1879934 has been published and should fix the issue.  Can
anyone confirm, please?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7840] description exists for non-existent rule USER_IN_WELCOMELIST_TO

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7840

--- Comment #10 from Kevin A. McGrail <km...@apache.org> ---
Thanks Bill for that insight.  

I show the ruleset 1879934 was published and has the fix.  Please confirm if
you can update now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7840] description exists for non-existent rule USER_IN_WELCOMELIST_TO

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7840

Bill Cole <bi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |billcole@apache.org

--- Comment #9 from Bill Cole <bi...@apache.org> ---
(In reply to Kevin A. McGrail from comment #8)
> Ty, working to figure out why the fix isn't being published in the rules

It's an update timing issue. The latest rev to be published is r1879882 but the
fix was in r1879885:

    # svn log rules/60_whitelist.cf |head -5
    ------------------------------------------------------------------------
    r1879885 | kmcgrail | 2020-07-15 08:02:46 -0400 (Wed, 15 Jul 2020) | 1 line

    Much cleaner to keep one rule name but use a if condition to set which eval
is called.  This fixes bug 7840
    ------------------------------------------------------------------------

And as noted in bug 7838: this is a transient noise problem, because there are
no functional changes to actual rules since this problem arose.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7840] description exists for non-existent rule USER_IN_WELCOMELIST_TO

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7840

Sebastian J. Bronner <wa...@sbronner.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |waschtl@sbronner.com

--- Comment #1 from Sebastian J. Bronner <wa...@sbronner.com> ---
I meant: See also the ongoing discussion in bug 7826.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7840] description exists for non-existent rule USER_IN_WELCOMELIST_TO

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7840

Kevin A. McGrail <km...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@apache.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Kevin A. McGrail <km...@apache.org> ---
This is a lint warning.  A fix was committed a few days ago but I had to work
out a merge complaint on the rule system publishing this morning.  I
believe a fix is now published.

Can you try now and lmk, please?  I think the current ruleset is 1879881
has it fixed and is published.

However SA 3.4.3+ will still install updates with just a warning.  Can
you upgrade your SA or are you stuck at 3.4.2?

If you still show the issue, what is the output of this command?
 sa-update -D --checkonly 2>&1 | grep -i dns

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7840] description exists for non-existent rule USER_IN_WELCOMELIST_TO

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7840

--- Comment #8 from Kevin A. McGrail <km...@apache.org> ---
Ty, working to figure out why the fix isn't being published in the rules

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7840] description exists for non-existent rule USER_IN_WELCOMELIST_TO

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7840

--- Comment #7 from Sebastian J. Bronner <wa...@sbronner.com> ---
Thanks Kevin, for responding so fast. It seems that your changes aren't yet
published on all mirrors:

$ /usr/bin/sa-update -D --checkonly 2>&1 | grep -i dns
Jul 17 11:28:29.942 [28189] dbg: diag: [...] module installed: Net::DNS,
version 1.1
Jul 17 11:28:29.943 [28189] dbg: diag: [...] module installed:
Net::DNS::Nameserver, version 1558
Jul 17 11:28:29.966 [28189] dbg: dns: 2.4.3.updates.spamassassin.org =>
1879882, parsed as 1879882

For the moment, I am still stuck with 3.4.2. I will be upgrading to Ubuntu
20.04 with 3.4.4 as time allows, but that will still be a while.

-- 
You are receiving this mail because:
You are the assignee for the bug.