You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Qian Xu <qi...@intel.com> on 2015/04/06 18:14:56 UTC
Re: Review Request 32242: SQOOP-2234 Sqoop2: Move DatasetURIValidator
to Kite package as it's not generally usable validator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32242/#review78925
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Xu
On March 20, 2015, 1:19 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32242/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 1:19 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2234
> https://issues.apache.org/jira/browse/SQOOP-2234
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Moved the validator to Kite's connector maven module.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/validation/validators/DatasetURIValidator.java ad298ed
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/FromJobConfig.java 68a1d7a
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ToJobConfig.java 07ee8cf
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/validators/DatasetURIValidator.java PRE-CREATION
> connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/validators/TestDatasetURIValidator.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32242/diff/
>
>
> Testing
> -------
>
> Added unit test for the validator to add some value during the move :)
>
>
> Thanks,
>
> Jarek Cecho
>
>