You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/03/09 13:55:27 UTC

[GitHub] [hbase-thirdparty] busbey commented on a change in pull request #15: HBASE-19256. [hbase-thirdparty] shade jetty.

busbey commented on a change in pull request #15: HBASE-19256. [hbase-thirdparty] shade jetty.
URL: https://github.com/apache/hbase-thirdparty/pull/15#discussion_r389694321
 
 

 ##########
 File path: hbase-shaded-miscellaneous/pom.xml
 ##########
 @@ -89,6 +89,38 @@
                   <pattern>org.apache.commons</pattern>
                   <shadedPattern>${rename.offset}.org.apache.commons</shadedPattern>
                 </relocation>
+                <relocation>
+                  <pattern>org.eclipse.jetty</pattern>
+                  <shadedPattern>${rename.offset}.org.eclipse.jetty</shadedPattern>
+                </relocation>
+                <relocation>
+                  <pattern>javax</pattern>
 
 Review comment:
   this is dangerous because the javax package is special within the JDK specs. classes in this package should be part of the JDK or a JSR, so ideally we wouldn't need to shade them.
   
   what is this trying to relocate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services