You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/26 01:13:31 UTC

[GitHub] [incubator-superset] craig-rueda opened a new pull request #8653: Adding app context wrapper to Celery tasks

craig-rueda opened a new pull request #8653: Adding app context wrapper to Celery tasks
URL: https://github.com/apache/incubator-superset/pull/8653
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [x] Enhancement (new features, refinement)
   
   ### SUMMARY
   We noticed that after my previous PR, Celery tasks weren't working properly, with an error being emitted around the lack of an active app context. This PR addresses the lack of app context. We also noticed that the loggers in sql_lab weren't following best practices around fetching loggers at bootstrap time.
   
   * Adds app_context wrapper around all calls to Celery tasks
   * Migrating from logging.xxx() to logging.getLogger with subsequent calls to resulting logger
   
   ### REVIEWERS
   @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org