You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "fwc (via GitHub)" <gi...@apache.org> on 2026/08/27 16:46:48 UTC
[PR] Sqt backport 4.2 [spark]
fwc opened a new pull request, #58350:
URL: https://github.com/apache/spark/pull/58350
### What changes were proposed in this pull request?
Test-util backport of `SessionQueryTest` trait.
### Why are the changes needed?
Simplifies `SessionQueryTest` adoption in downstream projects that build against Spark 4.2
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Test-only change
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59058] Backport SessionQueryTest to Spark 4.2 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58350:
URL: https://github.com/apache/spark/pull/58350#issuecomment-5442633813
Let me close this PR first. We can continue to discuss on the closed PR .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59058] Backport SessionQueryTest to Spark 4.2 [spark]
Posted by "fwc (via GitHub)" <gi...@apache.org>.
fwc commented on PR #58350:
URL: https://github.com/apache/spark/pull/58350#issuecomment-5442854876
Hi,
thanks for pointing out the guideline!
The change is test-only (plus the `private[connect] explainString`) and append-only (except removing obsolete `sql` declarations and reshuffling the `SharedSparkSession` and `checkError` code).
Delta Lake currently has to awkwardl vendor this code to use it ([link](https://github.com/delta-io/delta/blob/master/spark/src/test/scala/org/apache/spark/sql/SessionQueryTest.scala)) and it is useful for simplerclassic-/connect agnostic tests there.
This change should only (positively) impact downstream devs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59058] Backport SessionQueryTest to Spark 4.2 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58350:
URL: https://github.com/apache/spark/pull/58350#issuecomment-5443049144
No, this is a violation of contact between the Apache Spark main repository and the downstream projects (and developers) because the *release branches* are the common-well for all downstream projects and companies which already finish their test CI infrastructure.
Not only `branch-4.2`,
- `branch-4.3` also already entered `Feature Freeze` this month and will have RC1 next week.
- `branch-4.4` already entered `Feature Only` status by rejecting all dependency changes.
As a member of Apache Spark PMC, I'd like to recommend you to participate the community release cadence in advance. For example, if you want to backport some test framework to `branch-4.4`, it could be acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59058] Backport SessionQueryTest to Spark 4.2 [spark]
Posted by "fwc (via GitHub)" <gi...@apache.org>.
fwc commented on PR #58350:
URL: https://github.com/apache/spark/pull/58350#issuecomment-5443114867
Thx for the clarification! 🫡
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59058] Backport SessionQueryTest to Spark 4.2 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #58350: [SPARK-59058] Backport SessionQueryTest to Spark 4.2
URL: https://github.com/apache/spark/pull/58350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org