You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/27 16:35:23 UTC
[GitHub] [dolphinscheduler] github-code-scanning[bot] commented on a diff in pull request #13284: Add projectCode in t_ds_process_instance and t_ds_task_instance to avoid join
github-code-scanning[bot] commented on code in PR #13284:
URL: https://github.com/apache/dolphinscheduler/pull/13284#discussion_r1057778111
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java:
##########
@@ -82,18 +83,18 @@
* @param otherParamsJson otherParamsJson handle other params
* @return process instance list
*/
- Result queryProcessInstanceList(User loginUser,
- long projectCode,
- long processDefineCode,
- String startDate,
- String endDate,
- String searchVal,
- String executorName,
- WorkflowExecutionStatus stateType,
- String host,
- String otherParamsJson,
- Integer pageNo,
- Integer pageSize);
+ Result<PageInfo<ProcessInstance>> queryProcessInstanceList(User loginUser,
+ long projectCode,
+ long processDefineCode,
+ String startDate,
+ String endDate,
+ String searchVal,
+ String executorName,
+ WorkflowExecutionStatus stateType,
+ String host,
+ String otherParamsJson,
Review Comment:
## Useless parameter
The parameter 'otherParamsJson' is never used.
[Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/2443)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org