You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Michael Wyraz <mi...@evermind.de> on 2012/03/12 11:51:29 UTC
Patch for TAP5-1844
Hi,
this is my first T5 patch. Please correct me if submission here is wrong.
It is for my issue TAP5-1844 and adds an "onchange" event to the
datepicker component.
Index:
tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/datefield.js
===================================================================
---
tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/datefield.js
(Revision 1299618)
+++
tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/datefield.js
(Arbeitskopie)
@@ -114,7 +114,10 @@
var date = this.datePicker.getDate();
var resultHandler = function(result) {
- this.field.value = result;
+ if (this.field.value != result) {
+ this.field.value = result;
+ if (this.field.onchange) this.field.onchange();
+ }
this.hidePopup();
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Patch for TAP5-1844
Posted by CHAUVEL <mo...@gmail.com>.
Hi there,
I have a problem with the datefield component. I know how to solve it but I
can't find the following folder:
tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/corelib/components/datefield.js
Any help will be very apreciated!
--
View this message in context: http://tapestry.1045711.n5.nabble.com/Patch-for-TAP5-1844-tp5557263p5626640.html
Sent from the Tapestry - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Patch for TAP5-1844
Posted by Dragan Sahpaski <dr...@gmail.com>.
On Mon, Mar 12, 2012 at 1:23 PM, Michael Wyraz <mi...@evermind.de>wrote:
> Ok, i'll do so. Simply paste it as comment?
>
Well, no.
see here for an example https://issues.apache.org/jira/browse/TAP5-1848 of
an attached file.
You should attach a patch file and while uploading you will get a dialog
weather you will allow apache to use it or no.
Cheers
> It would be better if you submit the patch to the jira issue and allow
>> Apache to use it.
>>
>> Cheers,
>> Dragan Sahpaski
>>
>>
>>
>> On Mon, Mar 12, 2012 at 11:51 AM, Michael Wyraz
>> <mi...@evermind.de>**wrote:
>>
>> Hi,
>>>
>>> this is my first T5 patch. Please correct me if submission here is wrong.
>>>
>>> It is for my issue TAP5-1844 and adds an "onchange" event to the
>>> datepicker component.
>>>
>>> Index: tapestry-core/src/main/****resources/org/apache/**
>>> tapestry5/corelib/components/****datefield.js
>>> ==============================****============================**
>>> ==**=======
>>> --- tapestry-core/src/main/****resources/org/apache/**
>>> tapestry5/corelib/components/****datefield.js (Revision 1299618)
>>> +++ tapestry-core/src/main/****resources/org/apache/**
>>> tapestry5/corelib/components/****datefield.js (Arbeitskopie)
>>>
>>> @@ -114,7 +114,10 @@
>>> var date = this.datePicker.getDate();
>>>
>>> var resultHandler = function(result) {
>>> - this.field.value = result;
>>> + if (this.field.value != result) {
>>> + this.field.value = result;
>>> + if (this.field.onchange) this.field.onchange();
>>> + }
>>>
>>> this.hidePopup();
>>>
>>>
>>> ------------------------------****----------------------------**
>>> --**---------
>>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.**apa**che.org<http://apache.org>
>>> <de...@tapestry.apache.org>
>>> >
>>>
>>> For additional commands, e-mail: dev-help@tapestry.apache.org
>>>
>>>
>>>
>
> --
> Mit freundlichen Grüßen / Regards
>
> Michael Wyraz
>
> evermind GmbH
> Schorlemmerstraße 1
> 04155 Leipzig
>
> Tel.: +49 (0)341-25 39 66 - 0
> Fax: +49 (0)341-25 39 66 - 1
> Funk: +49 (0)177-73 00 00 3
> E-Mail: michael.wyraz@evermind.de
>
> HRB: 21586
> Amtsgericht Leipzig
>
> Geschäftsführer:
> Christoph Klemm
> Thomas Grünert
> Michael Wyraz
>
>
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.**apache.org<de...@tapestry.apache.org>
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>
Re: Patch for TAP5-1844
Posted by Michael Wyraz <mi...@evermind.de>.
Ok, i'll do so. Simply paste it as comment?
> It would be better if you submit the patch to the jira issue and allow
> Apache to use it.
>
> Cheers,
> Dragan Sahpaski
>
>
>
> On Mon, Mar 12, 2012 at 11:51 AM, Michael Wyraz
> <mi...@evermind.de>wrote:
>
>> Hi,
>>
>> this is my first T5 patch. Please correct me if submission here is wrong.
>>
>> It is for my issue TAP5-1844 and adds an "onchange" event to the
>> datepicker component.
>>
>> Index: tapestry-core/src/main/**resources/org/apache/**
>> tapestry5/corelib/components/**datefield.js
>> ==============================**==============================**=======
>> --- tapestry-core/src/main/**resources/org/apache/**
>> tapestry5/corelib/components/**datefield.js (Revision 1299618)
>> +++ tapestry-core/src/main/**resources/org/apache/**
>> tapestry5/corelib/components/**datefield.js (Arbeitskopie)
>> @@ -114,7 +114,10 @@
>> var date = this.datePicker.getDate();
>>
>> var resultHandler = function(result) {
>> - this.field.value = result;
>> + if (this.field.value != result) {
>> + this.field.value = result;
>> + if (this.field.onchange) this.field.onchange();
>> + }
>>
>> this.hidePopup();
>>
>>
>> ------------------------------**------------------------------**---------
>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.**apache.org<de...@tapestry.apache.org>
>> For additional commands, e-mail: dev-help@tapestry.apache.org
>>
>>
--
Mit freundlichen Grüßen / Regards
Michael Wyraz
evermind GmbH
Schorlemmerstraße 1
04155 Leipzig
Tel.: +49 (0)341-25 39 66 - 0
Fax: +49 (0)341-25 39 66 - 1
Funk: +49 (0)177-73 00 00 3
E-Mail: michael.wyraz@evermind.de
HRB: 21586
Amtsgericht Leipzig
Geschäftsführer:
Christoph Klemm
Thomas Grünert
Michael Wyraz
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Patch for TAP5-1844
Posted by Dragan Sahpaski <dr...@gmail.com>.
It would be better if you submit the patch to the jira issue and allow
Apache to use it.
Cheers,
Dragan Sahpaski
On Mon, Mar 12, 2012 at 11:51 AM, Michael Wyraz
<mi...@evermind.de>wrote:
> Hi,
>
> this is my first T5 patch. Please correct me if submission here is wrong.
>
> It is for my issue TAP5-1844 and adds an "onchange" event to the
> datepicker component.
>
> Index: tapestry-core/src/main/**resources/org/apache/**
> tapestry5/corelib/components/**datefield.js
> ==============================**==============================**=======
> --- tapestry-core/src/main/**resources/org/apache/**
> tapestry5/corelib/components/**datefield.js (Revision 1299618)
> +++ tapestry-core/src/main/**resources/org/apache/**
> tapestry5/corelib/components/**datefield.js (Arbeitskopie)
> @@ -114,7 +114,10 @@
> var date = this.datePicker.getDate();
>
> var resultHandler = function(result) {
> - this.field.value = result;
> + if (this.field.value != result) {
> + this.field.value = result;
> + if (this.field.onchange) this.field.onchange();
> + }
>
> this.hidePopup();
>
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.**apache.org<de...@tapestry.apache.org>
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>