You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/16 09:50:24 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7319: fs/procfs: Change FS_PROCFS_EXCLUDE_xxx default value to DEFAULT_SMALL

pkarashchenko commented on code in PR #7319:
URL: https://github.com/apache/incubator-nuttx/pull/7319#discussion_r996418603


##########
fs/procfs/fs_procfs.c:
##########
@@ -184,27 +184,24 @@ static const struct procfs_entry_s g_procfs_entries[] =
 #if defined(CONFIG_DEBUG_TCBINFO) && !defined(CONFIG_FS_PROCFS_EXCLUDE_TCBINFO)
   { "tcbinfo",       &tcbinfo_operations,         PROCFS_FILE_TYPE   },
 #endif
+  { NULL,            NULL,                        PROCFS_UNKOWN_TYPE },
 };
 
 #ifdef CONFIG_FS_PROCFS_REGISTER
 static const uint8_t g_base_entrycount = sizeof(g_base_entries) /

Review Comment:
   why do we need `g_base_entrycount` if array us already NULL terminated and can be just `while`-ed till `pathpattern != NULL`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org