You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mattyb149 <gi...@git.apache.org> on 2018/05/21 17:55:49 UTC
[GitHub] nifi pull request #2728: NIFI-5143: Initial work to support column values fo...
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2728
NIFI-5143: Initial work to support column values for paging results
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5143
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2728.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2728
----
commit bc614ce908addb3c961ae4aeb18879b4801c570a
Author: Matthew Burgess <ma...@...>
Date: 2018-05-21T17:45:16Z
NIFI-5143: Initial work to support column values for paging results
----
---
[GitHub] nifi issue #2728: NIFI-5143: Support column values for paging results
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2728
@pvillard31 I added an Additional Details page per your request. It is complicated behavior so definitely needed more explanation, hopefully it's not too confusing :)
---
[GitHub] nifi issue #2728: NIFI-5143: Support column values for paging results
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2728
reviewing...
---
[GitHub] nifi pull request #2728: NIFI-5143: Support column values for paging results
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2728
---
[GitHub] nifi issue #2728: NIFI-5143: Support column values for paging results
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2728
Code LGTM. I won't be a position to test all the adapters but will do some tests later (I'm in the middle of something else right now but should be able to get back on this tomorrow).
---
[GitHub] nifi issue #2728: NIFI-5143: Support column values for paging results
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2728
OK, I've been doing some tests against a Postgres database and everything is working as I'd expect. I've only one minor feedback regarding the property description.
> This property should only be used when the default queries are not performing well, when there is no maximum-value column or a single maximum-value column whose type can be coerced to a long integer (i.e. not date or timestamp), and the column values are evenly distributed and not sparse, for best performance.
I'd just add something regarding the "and the column values are evenly distributed and not sparse": I'd say that if this condition is not met, it could generate a lot of flow files (and back-pressure won't apply), and a lot of the generated queries would lead to query execution with no returned rows.
Not saying this should be added in the property description, but it could be something nice to add/mention in an "additional details" page?
That's really minor and can be ignored. Overall I'm a +1 on this PR and can merge whenever that's OK for you.
---
[GitHub] nifi issue #2728: NIFI-5143: Support column values for paging results
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2728
Great, thanks @mattyb149 !
Merging to master.
---