You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/12/16 23:05:10 UTC
[GitHub] [hbase] xcangCRM commented on a change in pull request #754:
HBASE-22978 : Online slow response log
xcangCRM commented on a change in pull request #754: HBASE-22978 : Online slow response log
URL: https://github.com/apache/hbase/pull/754#discussion_r358513045
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
##########
@@ -496,11 +515,44 @@ void logResponse(Message param, String methodName, String call, String tag,
}
}
}
- responseInfo.put("multi.gets", numGets);
- responseInfo.put("multi.mutations", numMutations);
- responseInfo.put("multi.servicecalls", numServiceCalls);
+ responseInfo.put(MULTI_GETS, numGets);
+ responseInfo.put(MULTI_MUTATIONS, numMutations);
+ responseInfo.put(MULTI_SERVICECALLS, numServiceCalls);
}
+ final String tag = tooLarge ? "TooLarge" : "TooSlow";
LOG.warn("(response" + tag + "): " + GSON.toJson(responseInfo));
+ if (!tooLarge && this.onlineSlowLogProvider != null
Review comment:
Are you nog handling tooLarge cases here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services