You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "markusmueller (via GitHub)" <gi...@apache.org> on 2023/12/18 16:11:14 UTC
[PR] Allow disabling optional features bulk, etags and sorting in ServerCo… [directory-scimple]
markusmueller opened a new pull request, #455:
URL: https://github.com/apache/directory-scimple/pull/455
Bulk, Sorting and Etags are defined optional in the spec. This changes allows subclasses of ServerConfig to disable these features by overwriting the setters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Allow overriding getters in ServerConfiguration [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers merged PR #455:
URL: https://github.com/apache/directory-scimple/pull/455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Allow disabling optional features bulk, etags and sorting in ServerCo… [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on code in PR #455:
URL: https://github.com/apache/directory-scimple/pull/455#discussion_r1430398787
##########
scim-server/src/main/java/org/apache/directory/scim/server/configuration/ServerConfiguration.java:
##########
@@ -86,15 +86,15 @@ public SupportedConfiguration getChangePasswordConfiguration() {
public BulkConfiguration getBulkConfiguration() {
BulkConfiguration bulkConfiguration = new BulkConfiguration();
- bulkConfiguration.setSupported(supportsBulk);
+ bulkConfiguration.setSupported(isSupportsBulk());
bulkConfiguration.setMaxOperations(bulkMaxOperations);
bulkConfiguration.setMaxPayloadSize(bulkMaxPayloadSize);
Review Comment:
Nice suggestion!
To keep this class constant, can you use the getters elsewhere in this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Allow overriding getters in ServerConfiguration [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #455:
URL: https://github.com/apache/directory-scimple/pull/455#issuecomment-1861926983
Thanks @markusmueller !!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Allow disabling optional features bulk, etags and sorting in ServerCo… [directory-scimple]
Posted by "markusmueller (via GitHub)" <gi...@apache.org>.
markusmueller commented on code in PR #455:
URL: https://github.com/apache/directory-scimple/pull/455#discussion_r1430471149
##########
scim-server/src/main/java/org/apache/directory/scim/server/configuration/ServerConfiguration.java:
##########
@@ -86,15 +86,15 @@ public SupportedConfiguration getChangePasswordConfiguration() {
public BulkConfiguration getBulkConfiguration() {
BulkConfiguration bulkConfiguration = new BulkConfiguration();
- bulkConfiguration.setSupported(supportsBulk);
+ bulkConfiguration.setSupported(isSupportsBulk());
bulkConfiguration.setMaxOperations(bulkMaxOperations);
bulkConfiguration.setMaxPayloadSize(bulkMaxPayloadSize);
Review Comment:
Yes, you are right, I have changed getter usage in all possible cases.
##########
scim-server/src/main/java/org/apache/directory/scim/server/configuration/ServerConfiguration.java:
##########
@@ -86,15 +86,15 @@ public SupportedConfiguration getChangePasswordConfiguration() {
public BulkConfiguration getBulkConfiguration() {
BulkConfiguration bulkConfiguration = new BulkConfiguration();
- bulkConfiguration.setSupported(supportsBulk);
+ bulkConfiguration.setSupported(isSupportsBulk());
bulkConfiguration.setMaxOperations(bulkMaxOperations);
bulkConfiguration.setMaxPayloadSize(bulkMaxPayloadSize);
Review Comment:
Yes, you are right, I have changed to getter usage in all possible cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Allow disabling optional features bulk, etags and sorting in ServerCo… [directory-scimple]
Posted by "markusmueller (via GitHub)" <gi...@apache.org>.
markusmueller commented on code in PR #455:
URL: https://github.com/apache/directory-scimple/pull/455#discussion_r1430471149
##########
scim-server/src/main/java/org/apache/directory/scim/server/configuration/ServerConfiguration.java:
##########
@@ -86,15 +86,15 @@ public SupportedConfiguration getChangePasswordConfiguration() {
public BulkConfiguration getBulkConfiguration() {
BulkConfiguration bulkConfiguration = new BulkConfiguration();
- bulkConfiguration.setSupported(supportsBulk);
+ bulkConfiguration.setSupported(isSupportsBulk());
bulkConfiguration.setMaxOperations(bulkMaxOperations);
bulkConfiguration.setMaxPayloadSize(bulkMaxPayloadSize);
Review Comment:
Yes, you are right, I have changed to getter usage in all possible places.
Any idea why bulk, sort and etag have setter access level private in the first place? Maybe the intention has been to not encourage disabling those?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org