[GitHub] [druid] kfaraz commented on pull request #12026: Fix vulnerabilities in some HTTP endpoints

[GitBox <gi...@apache.org>]

kfaraz commented on pull request #12026:
URL: https://github.com/apache/druid/pull/12026#issuecomment-986455960


   Thanks for the changes, @FrankChen021!
   This makes the error responses much cleaner!
   
   I had a couple of minor suggestions:
   - In `ResponseStatusExceptionMapper`, consider changing the signature of method `.toResponse()` to include `Object... args` so that the `String.format` can be done there instead of every caller having to do it.
   - Consider adding a syntax sugar for bad request and not found (as these are most commonly used) over `.toResponse()` i.e. something like `.toBadRequestResponse()` so that the caller can skip passing the `Response.Status.BAD_REQUEST` in the common cases. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org