You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Shankar Ramamoorthy (Jira)" <ji...@apache.org> on 2021/06/09 13:13:00 UTC
[jira] [Comment Edited] (CAMEL-16605) camel-zipkin custom tags
should be attached to exchange automatically
[ https://issues.apache.org/jira/browse/CAMEL-16605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360052#comment-17360052 ]
Shankar Ramamoorthy edited comment on CAMEL-16605 at 6/9/21, 1:12 PM:
----------------------------------------------------------------------
[~ashu6397] [~davsclaus] I think I get it now. Please let me know if I have understood correctly and I will code it up. The proposal is to add the ability to specify "global" - as opposed to per-Exchange - client custom tags on `ZipkinTracer` say via a new method `setClientCustomTags` and then have the global client custom tags be automatically added to the span in `ZipkinClientRequestAdapter#onExchange()`. The global tags would be in addition to the ones on the `Exchange` specified via `camel.client.customtags`. Please validate my understanding.
was (Author: maqroll):
I think I get it now. Please let me know if I have understood correctly and I will code it up. The proposal is to add the ability to specify "global" - as opposed to per-Exchange - client custom tags on `ZipkinTracer` say via a new method `setClientCustomTags` and then have the global client custom tags be automatically added to the span in `ZipkinClientRequestAdapter#onExchange()`. The global tags would be in addition to the ones on the `Exchange` specified via `camel.client.customtags`. Please validate my understanding.
> camel-zipkin custom tags should be attached to exchange automatically
> ---------------------------------------------------------------------
>
> Key: CAMEL-16605
> URL: https://issues.apache.org/jira/browse/CAMEL-16605
> Project: Camel
> Issue Type: Improvement
> Components: camel-zipkin
> Affects Versions: 3.x
> Reporter: Ashutosh Vaish
> Priority: Major
> Fix For: 3.x
>
>
> Thought about auto-configuring the camel-zipkin +*camel.client.customtags*+ from properties as key value pairs. Developer has to force-fully inject these custom tags at every route. This seems a duplicate work which can be attached to every span automatically by the library.
> https://github.com/apache/camel/blob/2f3b1e0d3c6cf0e01f5f62ddcf784f285aecb51c/components/camel-zipkin/src/main/java/org/apache/camel/zipkin/ZipkinClientRequestAdapter.java#L60
--
This message was sent by Atlassian Jira
(v8.3.4#803005)