You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/10 14:08:22 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #8954: Wait for pipeline state in Data Fusion operators

mik-laj commented on a change in pull request #8954:
URL: https://github.com/apache/airflow/pull/8954#discussion_r438150533



##########
File path: airflow/providers/google/cloud/hooks/datafusion.py
##########
@@ -357,12 +419,40 @@ def list_pipelines(
             )
         return json.loads(response.data)
 
+    def _get_workflow_state(
+        self,
+        pipeline_name: str,
+        instance_url: str,
+        pipeline_id: str,
+        namespace: str = "default",
+    ) -> str:
+        url = os.path.join(
+            instance_url,
+            "v3",
+            "namespaces",
+            namespace,
+            "apps",
+            pipeline_name,
+            "workflows",
+            "DataPipelineWorkflow",
+            "runs",
+            pipeline_id,

Review comment:
       Should we URL encode this parameter?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org