You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@tsfile.apache.org by "ColinLeeo (via GitHub)" <gi...@apache.org> on 2026/10/17 09:51:14 UTC

[PR] [CPP] Support reading BOOLEAN RLE written with Java defaults [tsfile]

ColinLeeo opened a new pull request, #1019:
URL: https://github.com/apache/tsfile/pull/1019

   Java writes BOOLEAN columns with RLE by default, but the C++ decoder factory rejects BOOLEAN + RLE even though `Int32RleDecoder::read_boolean()` already exists. Reading these files therefore fails when the reader allocates the value decoder.
   
   This change routes BOOLEAN + RLE to the existing decoder and adds a factory regression test. The existing cross-language compatibility workflow now generates 12 additional Java fixtures using a schema with no explicit encoding, asserts that the Java default is RLE, and validates the on-wire encoding and every value in C++. The fixtures cover UNCOMPRESSED/LZ4/ZSTD/LZMA2, alternating bits, long true/false runs, mixed NULL pages, and all-NULL pages.
   
   Validation:
   - Reproduced the factory and Java-to-C++ fixture failures before the fix.
   - Java fixture generation and readback passed.
   - C++ readback of all 135 Java fixtures passed, including the 12 new BOOLEAN fixtures.
   - Encoding regression selection: 29 tests passed.
   - Additional RLE/reader regression selection: 48 tests passed (one existing disabled test).
   - Java and C++ Spotless checks and `git diff --check` passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CPP] Support reading BOOLEAN RLE written with Java defaults [tsfile]

Posted by "ColinLeeo (via GitHub)" <gi...@apache.org>.
ColinLeeo merged PR #1019:
URL: https://github.com/apache/tsfile/pull/1019


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org