You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by maryannxue <gi...@git.apache.org> on 2014/04/01 02:53:06 UTC
[GitHub] incubator-phoenix pull request: PHOENIX-905 Wrong calculation of m...
GitHub user maryannxue opened a pull request:
https://github.com/apache/incubator-phoenix/pull/24
PHOENIX-905 Wrong calculation of maxSetBit in ValueBitSet#or(ImmutableBytesWritable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maryannxue/incubator-phoenix master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-phoenix/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit 05b584181fe36102feca765886fcda75b770b2b2
Author: maryannxue <ma...@apache.org>
Date: 2014-02-12T21:41:53Z
Fix PHOENIX-44 Cannot create index on tables with case-sensitive schema names
commit 02af57c96476c9d205d07ba96974c49188a282fa
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T02:54:17Z
Merge remote-tracking branch 'asf/master'
commit bd20346da5336d3d240493fdbfbcd5cc03280810
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T03:08:23Z
PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries
commit 9a2ced8936d6cedbc44a4ed2de2c6f72f4f4307f
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T04:59:29Z
PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries
commit 20a97904e48829f8b412bcfb0ac2084259133126
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T05:53:21Z
PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries
commit 7568516fabfb416f5dcbfa89468b839963802a87
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T22:14:14Z
Revert "PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries"
This reverts commit 20a97904e48829f8b412bcfb0ac2084259133126.
commit 3fb95819959d22deb2c03e895d976e7d933007f2
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T22:14:56Z
Revert "PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries"
This reverts commit 9a2ced8936d6cedbc44a4ed2de2c6f72f4f4307f.
commit ca0b55d048a6c547a5d6b081dd84dea01011e5c1
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T22:16:13Z
Revert "PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries"
This reverts commit bd20346da5336d3d240493fdbfbcd5cc03280810.
commit c4df65791a163070362662aad7ce5916faa3c3d7
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T22:18:13Z
Merge remote-tracking branch 'asf/master'
commit 9b5df132480b6bd25c0c33dd818278a5fc1b3f55
Author: maryannxue <ma...@apache.org>
Date: 2014-02-21T22:22:38Z
PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries
commit 3e677489c0cb811c1bb3d266581330fe11fdd674
Author: maryannxue <ma...@apache.org>
Date: 2014-02-22T00:17:15Z
PHOENIX-68 Add Option "FAVOR_STAR_JOIN" to indicate if star join optimization is preferred for multi inner join queries
commit 776c1a11b286ebd358f9111f3ff1c99c3f7c7883
Author: maryannxue <ma...@apache.org>
Date: 2014-02-27T18:41:58Z
Merge remote-tracking branch 'asf/master'
commit 6d26e78096091624502d4382de23f655626bca58
Author: maryannxue <ma...@apache.org>
Date: 2014-02-28T19:36:38Z
Merge remote-tracking branch 'asf/master'
commit df561c8d8ab59651d7e797dc0da501cceb4c6030
Author: maryannxue <ma...@apache.org>
Date: 2014-02-28T19:48:06Z
PHOENIX-85 Refine error handling in HashJoinPlan execution and add warnings
commit 53631fa509e2a660241c717a4eb0c131b251ff5d
Author: maryannxue <ma...@apache.org>
Date: 2014-02-28T23:42:14Z
PHOENIX-85 Refine error handling in HashJoinPlan execution and add warnings
commit 4fb71128f6ac961acbba7db9c3041c53bd18a64a
Author: maryannxue <ma...@apache.org>
Date: 2014-03-01T01:53:26Z
Merge remote-tracking branch 'asf/master'
commit 6a800b53abc6b6dac24daff1eae74100d6c73b97
Author: maryannxue <ma...@apache.org>
Date: 2014-03-01T02:10:20Z
Merge remote-tracking branch 'asf/master'
commit af32148215ec4cb443ba9d79c705c94196f1ff03
Author: maryannxue <ma...@apache.org>
Date: 2014-03-03T01:26:48Z
Merge remote-tracking branch 'asf/master'
commit 012018d2f58cfb35f7574301c68314ead2f31b9d
Author: maryannxue <ma...@apache.org>
Date: 2014-03-03T01:30:49Z
PHOENIX-89 Statements are not closed using PhoenixConnection.executeStatements()
commit c4bd34ff11f75d00bb74008a03247889b3b0160a
Author: maryannxue <ma...@apache.org>
Date: 2014-03-31T01:52:33Z
Merge remote-tracking branch 'asf/master'
commit 8fce312e63138f23c1befcf3a7dbbb573275eaf1
Author: maryannxue <ma...@apache.org>
Date: 2014-03-31T01:59:00Z
PHOENIX-71 Support sub-joins
commit b1d9340e36f750c66b993eb5e8571371f36ca9f9
Author: maryannxue <ma...@apache.org>
Date: 2014-04-01T00:19:57Z
PHOENIX-71 Support sub-joins
commit a3c8f7572a5aa3704ec817f5c42d691df2b631f6
Author: maryannxue <ma...@apache.org>
Date: 2014-04-01T00:43:04Z
PHOENIX-905 Wrong calculation of maxSetBit in ValueBitSet#or(ImmutableBytesWritable)
commit 2a99a6d5062a37eb654796550347786195b91b89
Author: maryannxue <ma...@apache.org>
Date: 2014-04-01T00:50:22Z
PHOENIX-905 Wrong calculation of maxSetBit in ValueBitSet#or(ImmutableBytesWritable)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-phoenix pull request: PHOENIX-905 Wrong calculation of m...
Posted by jtaylor-sfdc <gi...@git.apache.org>.
Github user jtaylor-sfdc commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/24#issuecomment-39160360
Looks good - thanks for the fix. Without this fix, will a bigger array than necessary just be allocated, or will it cause behavior to not work correctly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-phoenix pull request: PHOENIX-905 Wrong calculation of m...
Posted by maryannxue <gi...@git.apache.org>.
Github user maryannxue commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/24#issuecomment-39166452
It would not work correctly.
- maxSetBit = Math.max(maxSetBit, nLongs * Bytes.SIZEOF_LONG - 1);
+ maxSetBit = Math.max(maxSetBit, nLongs * BITS_PER_LONG - 1);
maxSetBit would be smaller than it should be. Thus, toBytes() would not serialize all necessary bits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-phoenix pull request: PHOENIX-905 Wrong calculation of m...
Posted by maryannxue <gi...@git.apache.org>.
Github user maryannxue commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/24#issuecomment-39166827
Think this change should also go into 3.0 and 4.0. What's your opinion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-phoenix pull request: PHOENIX-905 Wrong calculation of m...
Posted by maryannxue <gi...@git.apache.org>.
Github user maryannxue commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/24#issuecomment-39178211
It caused problem when field count > 16 ( isVarLength() == true ) in the join scenario.
Guess it was the cause of https://issues.apache.org/jira/browse/PHOENIX-1 as well, though the table order in this case should be switched to reproduce the problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-phoenix pull request: PHOENIX-905 Wrong calculation of m...
Posted by jtaylor-sfdc <gi...@git.apache.org>.
Github user jtaylor-sfdc commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/24#issuecomment-39167211
Yes, definitely in 3.0 and 4.0. Perhaps your last change as well, b/c the current plan is to cut point releases from 3.0 and 4.0 and have master for non compatible type changes.
Would this cause at least 8 bytes worth of data to be serialized? So if you had more than 64 fields, you'd hit a problem? I'd like to understand if this is worthy of sinking the current RC.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---