You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/03 06:41:55 UTC

[GitHub] [superset] villebro commented on a change in pull request #18564: fix: sqllab schema select error msg

villebro commented on a change in pull request #18564:
URL: https://github.com/apache/superset/pull/18564#discussion_r798249101



##########
File path: superset-frontend/src/SqlLab/actions/sqlLab.js
##########
@@ -775,8 +775,10 @@ export function queryEditorSetDb(queryEditor, dbId) {
 }
 
 export function queryEditorSetSchema(queryEditor, schema) {
+  console.log('queryEditor', typeof queryEditor, '---schema -->', schema)
   return function (dispatch) {
-    const sync = isFeatureEnabled(FeatureFlag.SQLLAB_BACKEND_PERSISTENCE)
+    console.log('featureflag *******', isFeatureEnabled(FeatureFlag.SQLLAB_BACKEND_PERSISTENCE))

Review comment:
       Oops pt 2!

##########
File path: superset-frontend/src/SqlLab/actions/sqlLab.js
##########
@@ -775,8 +775,10 @@ export function queryEditorSetDb(queryEditor, dbId) {
 }
 
 export function queryEditorSetSchema(queryEditor, schema) {
+  console.log('queryEditor', typeof queryEditor, '---schema -->', schema)

Review comment:
       ```suggestion
     console.log('queryEditor', typeof queryEditor, '---schema -->', schema)
   ```
   Oops!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org