[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #138: HDDS-2417 Add the list trash command to the client side

[GitBox <gi...@apache.org>]

anuengineer commented on a change in pull request #138: HDDS-2417 Add the list trash command to the client side
URL: https://github.com/apache/hadoop-ozone/pull/138#discussion_r344504700
 
 

 ##########
 File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java
 ##########
 @@ -1592,4 +1595,43 @@ public OpenKeySession createFile(OmKeyArgs args,
     }
     return statusList;
   }
+
+  @Override
+  public List<RepeatedOmKeyInfo> listTrash(String volumeName,
+      String bucketName, String startKeyName, String keyPrefix, int maxKeys)
+      throws IOException {
+
+    Preconditions.checkArgument(Strings.isNullOrEmpty(volumeName),
+        "The volume name cannot be null or " +
+        "empty.  Please enter a valid volume name or use '*' as a wild card");
+
+    Preconditions.checkArgument(Strings.isNullOrEmpty(bucketName),
+        "The bucket name cannot be null or " +
+        "empty.  Please enter a valid bucket name or use '*' as a wild card");
 
 Review comment:
   As a future JIRA, I was thinking it might be useful to get just the list of buckets that are deleted. It might be interesting.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org