You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/22 08:35:46 UTC

[GitHub] [rocketmq] lizhanhui opened a new pull request, #4865: Support build with Bazel

lizhanhui opened a new pull request, #4865:
URL: https://github.com/apache/rocketmq/pull/4865

   This is to achieve goals described in https://github.com/apache/rocketmq/issues/4864


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223634976

   @RongtongJin I think some tests need to be repaired and things need to be informed before implementation. In addition, DO NOT MERGE your own PR without anyone's approval. I will revert this PR first.
   
   You are being excessively arrogant and rude. It's advisable not to be so. Inspect the changes, first. Things are not what you  claimed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223678497

   > @duhenglucky Given the status of the guideline itself being **DISCUSS**, it does not make sense to assume it is something of a consensus.
   
   Sorry for my fault of forgot to update the status of this RIP, this is the link to vote at that time: https://lists.apache.org/thread/7onbv6yrw7q4ytbhy3w3f2d0v4rtf4dl, Now I have updated the status, thanks for the reminder ：）


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] aaron-ai commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
aaron-ai commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223752225

   > Let's relax and focus on this PR, things should be moving forward, how about closing this issue in a new branch and then merging it to develop after every test case passed, I also want to be a volunteer to fix these unit tests. @lizhanhui
   > 
   > As for the merge convention, the community had a consensus, but that does not prevent us from discussing and polishing it continuously. For example, the so-called `core contributor` and by module rules are confusing and difficult to practice. IMO, we could have more discussions on the mailing list and apply the rules to [.asf.yaml](https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features) to reduce the labor burden once we have a new consensus.
   
   I agree with that, and we could discuss more details about mergeability in this issue #4870 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui merged pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
lizhanhui merged PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhouxinyu commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
zhouxinyu commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223649755

   Currently, the CI costs too much time, I also think changing the build system is a good attempt. If our members think more discussions are needed, let's do it. @RongtongJin
   
   Also, let's follow the community guidelines, merge after some approvals is the best practice, if we need a merge event to trigger the GitHub action in the test phase, consider using a new branch. @lizhanhui 
   
   Unfortunately, I couldn't find the detailed guidelines about the merge conditions on our website, shall we discuss and clear it ASAP?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223515590

   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4865?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#4865](https://codecov.io/gh/apache/rocketmq/pull/4865?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4f0e667) into [develop](https://codecov.io/gh/apache/rocketmq/commit/58c1d1efcb102464a433aecc8d36c34385744bc9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (58c1d1e) will **decrease** coverage by `1.67%`.
   > The diff coverage is `54.38%`.
   
   > :exclamation: Current head 4f0e667 differs from pull request most recent head 48a9d83. Consider uploading reports for the commit 48a9d83 to get more accurate results
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #4865      +/-   ##
   =============================================
   - Coverage      44.77%   43.09%   -1.68%     
   + Complexity      7642     7626      -16     
   =============================================
     Files            982      991       +9     
     Lines          68253    68507     +254     
     Branches        9023     9075      +52     
   =============================================
   - Hits           30561    29526    -1035     
   - Misses         33905    35248    +1343     
   + Partials        3787     3733      -54     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4865?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...org/apache/rocketmq/namesrv/NamesrvController.java](https://codecov.io/gh/apache/rocketmq/pull/4865/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9OYW1lc3J2Q29udHJvbGxlci5qYXZh) | `63.02% <0.00%> (-1.08%)` | :arrow_down: |
   | [...va/org/apache/rocketmq/namesrv/NamesrvStartup.java](https://codecov.io/gh/apache/rocketmq/pull/4865/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9OYW1lc3J2U3RhcnR1cC5qYXZh) | `16.66% <ø> (ø)` | |
   | [...a/org/apache/rocketmq/test/schema/SchemaTools.java](https://codecov.io/gh/apache/rocketmq/pull/4865/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC9zY2hlbWEvU2NoZW1hVG9vbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...java/org/apache/rocketmq/test/util/RandomUtil.java](https://codecov.io/gh/apache/rocketmq/pull/4865/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL1JhbmRvbVV0aWwuamF2YQ==) | `0.00% <0.00%> (-1.41%)` | :arrow_down: |
   | [...he/rocketmq/tools/admin/DefaultMQAdminExtImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4865/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2FkbWluL0RlZmF1bHRNUUFkbWluRXh0SW1wbC5qYXZh) | `25.49% <ø> (-0.18%)` | :arrow_down: |
   | [.../apache/rocketmq/tools/command/MQAdminStartup.java](https://codecov.io/gh/apache/rocketmq/pull/4865/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvTVFBZG1pblN0YXJ0dXAuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...and/acl/ClusterAclConfigVersionListSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4865/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvYWNsL0NsdXN0ZXJBY2xDb25maWdWZXJzaW9uTGlzdFN1YkNvbW1hbmQuamF2YQ==) | `20.40% <0.00%> (ø)` | |
   | [...s/command/consumer/ConsumerProgressSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4865/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvY29uc3VtZXIvQ29uc3VtZXJQcm9ncmVzc1N1YkNvbW1hbmQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...cketmq/acl/plain/RemoteAddressStrategyFactory.java](https://codecov.io/gh/apache/rocketmq/pull/4865/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWNsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9hY2wvcGxhaW4vUmVtb3RlQWRkcmVzc1N0cmF0ZWd5RmFjdG9yeS5qYXZh) | `89.51% <33.33%> (ø)` | |
   | [...e/rocketmq/remoting/netty/NettyRemotingServer.java](https://codecov.io/gh/apache/rocketmq/pull/4865/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdTZXJ2ZXIuamF2YQ==) | `59.62% <45.45%> (-1.77%)` | :arrow_down: |
   | ... and [108 more](https://codecov.io/gh/apache/rocketmq/pull/4865/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223632303

   > some test cases are ignored, will you open them later?
   Only one or two UNSTABLE cases are ignored for now. I plan to fix them in separate pr. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] francisoliverlee commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223445780

   hi li, why we need Bazel having Maven ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
duhenglucky commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223658814

   > 
   
   Actually, Here are some [specifications](https://github.com/apache/rocketmq/wiki/RIP-14-RocketMQ-Community-Operation-Conventions) on PR merging that have been voted by the community. I think it is better to follow these guidelines.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223694500

   > > @RongtongJin First, it is not a large PR, only a few lines of changes to main source files. Most of the changes are Bazel build files and fixes to test cases that are not hermetic or unstable, or not capable of running in parallel. Only a very few tests are temporarily disabled, which will be enabled in a separate PR. The focus of this PR is to enable Bazel, helping us build and run tests in parallel.
   > > Second, Infra team is waiting to confirm if they configured secrets correctly.
   > > As a member of the community, you, by no means, are supposed to revert contribution harshly, without even getting any response. This is not what a qualified PMC member should do, and can not make the community any way better in any perspective.
   > 
   > I agree with your last paragraph. In addition, we should not **treat yourself leniently and be strict with others**
   > 
   > ![image](https://user-images.githubusercontent.com/21963954/186101220-8834e9cf-5c8d-4664-ba8a-0597178b4b45.png)
   
   Read the context of that PR. You are purposely neglecting reviews, changing from one spell error to another. This is why the revert is necessary. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223664990

   @duhenglucky Given the status of the guideline itself being **DISCUSS**, it does not make sense to assume it is something of a consensus. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223686190

   > @RongtongJin First, it is not a large PR, only a few lines of changes to main source files. Most of the changes are Bazel build files and fixes to test cases that are not hermetic or unstable, or not capable of running in parallel. Only a very few tests are temporarily disabled, which will be enabled in a separate PR. The focus of this PR is to enable Bazel, helping us build and run tests in parallel.
   > 
   > Second, Infra team is waiting to confirm if they configured secrets correctly.
   > 
   > As a member of the community, you, by no means, are supposed to revert contribution harshly, without even getting any response. This is not what a qualified PMC member should do, and can not make the community any way better in any perspective.
   
   I agree with your last paragraph. In addition, we should not **treat yourself leniently and be strict with others**
   
   ![image](https://user-images.githubusercontent.com/21963954/186101220-8834e9cf-5c8d-4664-ba8a-0597178b4b45.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223674193

   > Given the status of the guideline itself being **DISCUSS**, it does not make sense to assume it is something of a consensus.
   
   This convention has been discussed on the mailing list. https://lists.apache.org/thread/7onbv6yrw7q4ytbhy3w3f2d0v4rtf4dl
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223665575

   > Currently, the CI costs too much time, I also think changing the build system is a good attempt. If our members think more discussions are needed, let's do it. @RongtongJin
   > 
   > Also, let's follow the community guidelines, merge after some approvals is the best practice, if we need a merge event to trigger the GitHub action in the test phase, consider using a new branch. @lizhanhui
   > 
   > Unfortunately, I couldn't find the detailed guidelines about the merge conditions on our website, shall we discuss and clear it ASAP?
   
   Hi @zhouxinyu I agree with you that we need to reduce the time of CI and think it is necessary. But why did the author merge such a large PR by himself without any notice? In addition, he ignored some necessary tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223689043

   > > > @duhenglucky Given the status of the guideline itself being **DISCUSS**, it does not make sense to assume it is something of a consensus.
   > > 
   > > 
   > > Sorry for my fault of forgetting to update the status of this RIP, this is the link to vote at that time: https://lists.apache.org/thread/7onbv6yrw7q4ytbhy3w3f2d0v4rtf4dl, Now I have updated the status, thanks for the reminder ：）
   > 
   > The RIP is obviously lack of thorough discussion. I suggest not to change it status in a haste. It's better to double review it since it would impact a lot in the community.
   
   So why didn't you participate in the discussion when I sent the discussion email?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223684949

   > > @duhenglucky Given the status of the guideline itself being **DISCUSS**, it does not make sense to assume it is something of a consensus.
   > 
   > Sorry for my fault of forgetting to update the status of this RIP, this is the link to vote at that time: https://lists.apache.org/thread/7onbv6yrw7q4ytbhy3w3f2d0v4rtf4dl, Now I have updated the status, thanks for the reminder ：）
   
   The RIP is obviously lack of thorough discussion. I suggest not to change it status in a haste. It's better to double review it since it would impact a lot in the community. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223678698

   @RongtongJin First, it is not a large PR, only a few lines of changes to main source files. Most of the changes are Bazel build files and fixes to test cases that are not hermetic or unstable, or not capable of running in parallel.  Only a very few tests are temporarily disabled, which will be enabled in a separate PR.  The focus of this PR is to enable Bazel, helping us build and run tests in parallel.
   
   Second, Infra team is waiting to confirm if they configured secrets correctly. 
   
   As a member of the community, you, by no means, are supposed to revert contribution harshly, without even getting any response. This is not what a qualified PMC member should do, and can not make the community any way better in any perspecitve. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223450850

   @francisoliverlee See the issue description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223760747

   > how about closing this issue in a new branch and then merging it to develop after every test case passed, I also want to be a volunteer to fix these unit tests. 
   
   This is the RocketMQ community it used to be and where the genuine Apache Way shines. It's okay to create a branch in the repository where we make every case pass and fix the rest flaky ones. 
   
   > As for the merge convention, the community had a consensus, but that does not prevent us from discussing and polishing it continuously. For example, the so-called core contributor and by module rules are confusing and difficult to practice. IMO, we could have more discussions on the mailing list and apply the rules to [.asf.yaml](https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features) to reduce the labor burden once we have a new consensus.
   
   Exactly. RIPs are not something fixed, if not deprecated.  They are consensus that helps the community. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223552502

   Merge to verify issue: https://issues.apache.org/jira/browse/INFRA-23612


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223611331

   Hi @lizhanhui I think this is a good idea to support build with Bazel, but I found that many tests were ignored. I think some tests need to be repaired and things need to be informed before implementation. In addition, **DO NOT MERGE** your own PR without anyone's approval. I will revert this PR first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223698500

   > > > > @duhenglucky Given the status of the guideline itself being **DISCUSS**, it does not make sense to assume it is something of a consensus.
   > > > 
   > > > 
   > > > Sorry for my fault of forgetting to update the status of this RIP, this is the link to vote at that time: https://lists.apache.org/thread/7onbv6yrw7q4ytbhy3w3f2d0v4rtf4dl, Now I have updated the status, thanks for the reminder ：）
   > > 
   > > 
   > > The RIP is obviously lack of thorough discussion. I suggest not to change it status in a haste. It's better to double review it since it would impact a lot in the community.
   > 
   > So why didn't you participate in the discussion when I sent the discussion email?
   
   This is not a normal RIP of specific features. If it would reflect continuous community consensus, it should be thoroughly reviewed and widely accepted. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] zhouxinyu commented on pull request #4865: Support build with Bazel

Posted by GitBox <gi...@apache.org>.
zhouxinyu commented on PR #4865:
URL: https://github.com/apache/rocketmq/pull/4865#issuecomment-1223730944

   Let's relax and focus on this PR, things should be moving forward, how about closing this issue in a new branch and then merging it to develop after every test case passed, I also want to be a volunteer to fix these unit tests. @lizhanhui 
   
   As for the merge convention, the community had a consensus, but that does not prevent us from discussing and polishing it continuously. For example, the so-called `core contributor` and by module rules are confusing and difficult to practice. IMO, we could have more discussions on the mailing list and apply the rules to [.asf.yaml](https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features) to reduce the labor burden once we have a new consensus.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org