You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/08/27 14:39:17 UTC

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #881: MINIFICPP-1342 Prevent patch reapplication in git-based ExtenalProjects

szaszm commented on pull request #881:
URL: https://github.com/apache/nifi-minifi-cpp/pull/881#issuecomment-681991265


   Just for the record:
   I initially thought the issue was this: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/4565 but it was present with cmake 3.18.
   Then I thought the issue might be because the update step if a `git pull --rebase`, which does nothing in our case, and is followed by a new patch application, but `GIT_REMOTE_UPDATE_STRATEGY CHECKOUT` didn't help either.
   
   I have no idea what the root cause is, but calling git reset before the patch application makes the operation idempotent, solving the build issues.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org