You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by JohnKiel <gi...@git.apache.org> on 2017/02/05 21:27:27 UTC
[GitHub] tomcat pull request #41: Check and update session record if one already exis...
GitHub user JohnKiel opened a pull request:
https://github.com/apache/tomcat/pull/41
Check and update session record if one already exists.
Check and update session record if one already exists, instead of deleting and re-inserting new record.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JohnKiel/tomcat trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
----
commit 1201037d0a89895c54fcf5e23302c8aa117e1106
Author: JohnKiel <jo...@gmail.com>
Date: 2017-02-05T21:24:43Z
Check and update session record if one already exists.
Check and update session record if one already exists, instead of deleting and re-inserting new record.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #41: Check and update session record if one already exists.
Posted by JohnKiel <gi...@git.apache.org>.
Github user JohnKiel commented on the issue:
https://github.com/apache/tomcat/pull/41
If you use SELECT FOR UPDATE, then you'll also need to start and commit a transaction, with the overhead that entails. If the record is modified or even deleted between the time the SELECT query and UPDATE, it's of little to no consequence, and no worse than the current delete/insert method. The worst result would be slightly stale session data being written, which is kind of an issue anyway if you have an application with that many threads all trying to save data for the same session at basically the same time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat issue #41: Check and update session record if one already exists.
Posted by ChristopherSchultz <gi...@git.apache.org>.
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/41
You should use SELECT ... FOR UPDATE instead of SELECT / UPDATE. Much less code and transactionally-safe. Also, if you use SELECT ... FOR UPDATE, you can use ResultSet.moveToInsertRow to insert a record if necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org